| Message ID | 20211103100235.22007-1-bogdan.lezhepekov@suse.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1] netns_netlink: Ensure tuntap is enabled in kernel | expand |
Hi! > testcases/kernel/containers/netns/netns_netlink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/testcases/kernel/containers/netns/netns_netlink.c b/testcases/kernel/containers/netns/netns_netlink.c > index ddd8ce910..f9ae255f5 100644 > --- a/testcases/kernel/containers/netns/netns_netlink.c > +++ b/testcases/kernel/containers/netns/netns_netlink.c > @@ -120,6 +120,7 @@ static struct tst_test test = { > .forks_child = 1, > .needs_kconfigs = (const char *[]) { > "CONFIG_NET_NS=y", > + "CONFIG_TUN=y", Shouldn't that be just "CONFIG_TUN" as that would match both "CONFIG_TUN=y" and "CONFIG_TUN=m"?
Hi Cyril, I was missing that it's possible with the test API. Then of course it would be better. Should I submit V2? Thanks, Bogdan
Hi! > I was missing that it's possible with the test API. Then of course it would be better. Actually the config parser implements full boolean expressions :-). > Should I submit V2? No need, I will remove the =y before applying.
Hi! I've fixed the kconfig line and also added your Signed-off-by and pushed, thanks. Please make sure that you commit your patches with -s
Hi, Thanks a lot! -Bogdan
diff --git a/testcases/kernel/containers/netns/netns_netlink.c b/testcases/kernel/containers/netns/netns_netlink.c index ddd8ce910..f9ae255f5 100644 --- a/testcases/kernel/containers/netns/netns_netlink.c +++ b/testcases/kernel/containers/netns/netns_netlink.c @@ -120,6 +120,7 @@ static struct tst_test test = { .forks_child = 1, .needs_kconfigs = (const char *[]) { "CONFIG_NET_NS=y", + "CONFIG_TUN=y", NULL }, };