Message ID | 20210531135314.5067-2-mdoucha@suse.cz |
---|---|
State | Accepted |
Headers | show |
Series | [1/2] network/busy_poll: Fix tests in namespaced env | expand |
Hi Martin, > Kernel v4.5 extended the busy_poll functionality to all network drivers. > Limiting the test only to drivers which implemented busy_poll as internal > feature on older kernels does not make sense. Ah, you mean 85c72ba1ed0c ("Merge branch 'net-generic-busy-polling'") Good catch, thx!! Fixes: ead28f929 ("busy_poll: skip busy_poll flag test on kernels 4.5+") Kind regards, Petr > Signed-off-by: Martin Doucha <mdoucha@suse.cz> > --- > testcases/network/busy_poll/busy_poll_lib.sh | 4 ---- > 1 file changed, 4 deletions(-) > diff --git a/testcases/network/busy_poll/busy_poll_lib.sh b/testcases/network/busy_poll/busy_poll_lib.sh > index 5270a1bbd..d17504466 100755 > --- a/testcases/network/busy_poll/busy_poll_lib.sh > +++ b/testcases/network/busy_poll/busy_poll_lib.sh > @@ -25,9 +25,5 @@ busy_poll_check_config() > ethtool --show-features $(tst_iface) | \ > grep -q 'busy-poll.*on' || \ > tst_brk TCONF "busy poll not supported by driver" > - else > - drvs="bnx2x|bnxt|cxgb4|enic|benet|ixgbe|ixgbevf|mlx4|mlx5|myri10ge|sfc|virtio" > - ethtool -i $(tst_iface) | grep -qE "driver: ($drvs)" || \ > - tst_brk TCONF "busy poll not supported" > fi > }
diff --git a/testcases/network/busy_poll/busy_poll_lib.sh b/testcases/network/busy_poll/busy_poll_lib.sh index 5270a1bbd..d17504466 100755 --- a/testcases/network/busy_poll/busy_poll_lib.sh +++ b/testcases/network/busy_poll/busy_poll_lib.sh @@ -25,9 +25,5 @@ busy_poll_check_config() ethtool --show-features $(tst_iface) | \ grep -q 'busy-poll.*on' || \ tst_brk TCONF "busy poll not supported by driver" - else - drvs="bnx2x|bnxt|cxgb4|enic|benet|ixgbe|ixgbevf|mlx4|mlx5|myri10ge|sfc|virtio" - ethtool -i $(tst_iface) | grep -qE "driver: ($drvs)" || \ - tst_brk TCONF "busy poll not supported" fi }
Kernel v4.5 extended the busy_poll functionality to all network drivers. Limiting the test only to drivers which implemented busy_poll as internal feature on older kernels does not make sense. Signed-off-by: Martin Doucha <mdoucha@suse.cz> --- testcases/network/busy_poll/busy_poll_lib.sh | 4 ---- 1 file changed, 4 deletions(-)