diff mbox series

fastopen: add require to sch_netem driver

Message ID 20201217085852.26032-1-kory.maincent@bootlin.com
State Accepted
Headers show
Series fastopen: add require to sch_netem driver | expand

Commit Message

Kory Maincent Dec. 17, 2020, 8:58 a.m. UTC 
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 testcases/network/tcp_fastopen/tcp_fastopen_run.sh | 1 +
 1 file changed, 1 insertion(+)

Comments

Petr Vorel Dec. 17, 2020, 1:25 p.m. UTC | #1 
Hi Kory,

> +TST_NEEDS_DRIVERS="sch_netem"
On my system also veth, xfrm_algo and xfrm_user are loaded.

veth is added because I use network namespaces based testing (I'll add it on
separate patch) and xfrm_algo is used xfrm_user.

Thus maybe add also xfrm_user?
TST_NEEDS_DRIVERS="sch_netem xfrm_user"

Kind regards,
Petr
Kory Maincent Dec. 17, 2020, 2:29 p.m. UTC | #2 
Hi Petr,

On Thu, 17 Dec 2020 14:25:59 +0100
Petr Vorel <pvorel@suse.cz> wrote:

> Hi Kory,
> 
> > +TST_NEEDS_DRIVERS="sch_netem"  
> On my system also veth, xfrm_algo and xfrm_user are loaded.
> 
> veth is added because I use network namespaces based testing (I'll add it on
> separate patch) and xfrm_algo is used xfrm_user.

The xfrm_user driver seems not to be needed for the fastopen test.

Regards,

Köry 

> 
> Thus maybe add also xfrm_user?
> TST_NEEDS_DRIVERS="sch_netem xfrm_user"
> 
> Kind regards,
> Petr
Petr Vorel Dec. 17, 2020, 3:01 p.m. UTC | #3 
Hi Kory,

> > > +TST_NEEDS_DRIVERS="sch_netem"  
> > On my system also veth, xfrm_algo and xfrm_user are loaded.

> > veth is added because I use network namespaces based testing (I'll add it on
> > separate patch) and xfrm_algo is used xfrm_user.

> The xfrm_user driver seems not to be needed for the fastopen test.
Thanks for info. Correct, it's loaded by ip xfrm in tst_init_iface()
(which is not required since 250438496).

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr
Petr Vorel Dec. 18, 2020, 10:58 a.m. UTC | #4 
Hi Kory,

thanks, merged!

Kind regards,
Petr
diff mbox series

Patch

diff --git a/testcases/network/tcp_fastopen/tcp_fastopen_run.sh b/testcases/network/tcp_fastopen/tcp_fastopen_run.sh
index fb2cb8fc2..0e59ed506 100755
--- a/testcases/network/tcp_fastopen/tcp_fastopen_run.sh
+++ b/testcases/network/tcp_fastopen/tcp_fastopen_run.sh
@@ -11,6 +11,7 @@  TST_MIN_KVER="3.7"
 TST_NEEDS_TMPDIR=1
 TST_NEEDS_ROOT=1
 TST_NEEDS_CMDS="tc"
+TST_NEEDS_DRIVERS="sch_netem"
 TST_OPTS="R:"
 TST_USAGE=tcp_fastopen_usage
 TST_PARSE_ARGS=tcp_fastopen_parse_args