diff mbox series

pty04: Fix read retries

Message ID 20200514133201.12829-1-rpalethorpe@suse.com
State Accepted
Headers show
Series pty04: Fix read retries | expand

Commit Message

Richard Palethorpe May 14, 2020, 1:32 p.m. UTC 
We need to increase the data pointer by the amount already read.

Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
---
 testcases/kernel/pty/pty04.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cyril Hrubis May 14, 2020, 1:39 p.m. UTC | #1 
Hi!
> We need to increase the data pointer by the amount already read.

Applied, thanks.

> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> ---
>  testcases/kernel/pty/pty04.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/pty/pty04.c b/testcases/kernel/pty/pty04.c
> index 68a84ea87..d574d8b2c 100644
> --- a/testcases/kernel/pty/pty04.c
> +++ b/testcases/kernel/pty/pty04.c
> @@ -294,7 +294,7 @@ static void try_read(int fd, char *data, ssize_t size)
>  	int retry = mtu;
>  
>  	while (retry--) {
> -		ret = read(fd, data, size - n);
> +		ret = read(fd, data + n, size - n);

Sorry for not catching that during the review...
diff mbox series

Patch

diff --git a/testcases/kernel/pty/pty04.c b/testcases/kernel/pty/pty04.c
index 68a84ea87..d574d8b2c 100644
--- a/testcases/kernel/pty/pty04.c
+++ b/testcases/kernel/pty/pty04.c
@@ -294,7 +294,7 @@  static void try_read(int fd, char *data, ssize_t size)
 	int retry = mtu;
 
 	while (retry--) {
-		ret = read(fd, data, size - n);
+		ret = read(fd, data + n, size - n);
 
 		if (ret < 0)
 			break;