diff mbox series

Update dynamic_debug grep check

Message ID 20191004184436.30922-1-rasibley@redhat.com
State Changes Requested
Headers show
Series Update dynamic_debug grep check | expand

Commit Message

rasibley Oct. 4, 2019, 6:44 p.m. UTC
If running on debug kernel this check will fail on EDAC DEBUG messages,
update grep to ignore such cases like this.
---
 testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cyril Hrubis Oct. 7, 2019, 2:03 p.m. UTC | #1
Hi!
> If running on debug kernel this check will fail on EDAC DEBUG messages,
> update grep to ignore such cases like this.

You are missing the Signed-off-by: line here, see:

https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

Otherwise the patch is Ok.

> ---
>  testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh b/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
> index f39d67d0a..7f06c2488 100755
> --- a/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
> +++ b/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
> @@ -127,7 +127,7 @@ ddebug_test()
>  	sed -i -e 1,`wc -l < ./dmesg.old`d ./dmesg.new
>  	if grep -q -e "Kernel panic" -e "Oops" -e "general protection fault" \
>  		-e "general protection handler: wrong gs" -e "\(XEN\) Panic" \
> -		-e "fault" -e "warn" -e "BUG" ./dmesg.new ; then
> +		-e "fault" -e "warn" -e "\<BUG\>" ./dmesg.new ; then
>  		tst_res TFAIL "Issues found in dmesg!"
>  	else
>  		tst_res TPASS "Dynamic debug OK"
> -- 
> 2.20.1
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp
Jan Stancek Oct. 7, 2019, 7:19 p.m. UTC | #2
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "rasibley" <rasibley@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Monday, 7 October, 2019 4:03:21 PM
> Subject: Re: [LTP] [PATCH] Update dynamic_debug grep check
> 
> Hi!
> > If running on debug kernel this check will fail on EDAC DEBUG messages,
> > update grep to ignore such cases like this.
> 
> You are missing the Signed-off-by: line here, see:
> 
> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

You can also use kernel scripts/checkpatch.pl.

> 
> Otherwise the patch is Ok.

Pushed with added Signed-off-by and tweaked commit message.

Thanks,
Jan
diff mbox series

Patch

diff --git a/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh b/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
index f39d67d0a..7f06c2488 100755
--- a/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
+++ b/testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh
@@ -127,7 +127,7 @@  ddebug_test()
 	sed -i -e 1,`wc -l < ./dmesg.old`d ./dmesg.new
 	if grep -q -e "Kernel panic" -e "Oops" -e "general protection fault" \
 		-e "general protection handler: wrong gs" -e "\(XEN\) Panic" \
-		-e "fault" -e "warn" -e "BUG" ./dmesg.new ; then
+		-e "fault" -e "warn" -e "\<BUG\>" ./dmesg.new ; then
 		tst_res TFAIL "Issues found in dmesg!"
 	else
 		tst_res TPASS "Dynamic debug OK"