Message ID | 20190604090824.15427-1-pcervinka@suse.com |
---|---|
State | Changes Requested |
Headers | show |
Series | [v2] Fix shebang in open-posix makefile generator | expand |
Hi! You are missing the Signed-off-by: line here, see: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin Other than that this is obviously OK.
diff --git a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh index 4666739f5..7b11c98bd 100755 --- a/testcases/open_posix_testsuite/scripts/generate-makefiles.sh +++ b/testcases/open_posix_testsuite/scripts/generate-makefiles.sh @@ -186,7 +186,7 @@ EOF if ! grep -q '^run.sh' "$makefile.3"; then cat >> "$makefile.3" <<EOF run.sh: - @echo '#/bin/sh' > \$@ + @echo '#!/bin/sh' > \$@ @echo "\$(top_srcdir)/bin/run-tests.sh \$(subdir) \$(INSTALL_TARGETS)" >> \$@ @chmod +x run.sh