From patchwork Wed Oct 10 23:34:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 982147 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YOslIeoL"; dkim-atps=neutral Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42Vr7Y2q3mz9s4Z for ; Thu, 11 Oct 2018 10:35:37 +1100 (AEDT) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 997363E70D2 for ; Thu, 11 Oct 2018 01:35:34 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) by picard.linux.it (Postfix) with ESMTP id 4714F3E70A5 for ; Thu, 11 Oct 2018 01:34:58 +0200 (CEST) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id F3B2C1A006E5 for ; Thu, 11 Oct 2018 01:34:57 +0200 (CEST) Received: by mail-wr1-x441.google.com with SMTP id d2-v6so7555581wro.7 for ; Wed, 10 Oct 2018 16:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8JBysDH3gdIhIID7hbG0vNGcorVxBHvqkKAA5hy08ZQ=; b=YOslIeoLFYzBPaoH0oUIKnXwIm2I9W0RP+8Skgo/coRootw23Tkf+Yb6hG9cbrWGkU BN0JF+BPuBbt2ipj8SFMm1QYdMgNO6LcPar0ZvHOOw/GVJKtzsXo+700YFaCQ8WA7dE0 8p9vA1kQoptHWl3If5ZoPNrROVHYeLw+UcsYqqoc9Z8hqa69t/nQ7mReFXKpmCQQEh5p tszPiqaDk9gvcbnhS3+0S+6LVgsj/LojZSDYYY182u95B/MEfTWc2YmEmI9ZND+Z3ZRP tr4KiEnqPipxX5KL5iHtTYs7LGsWEoTCtuip2rELDjqHVQ8sbKMrfztr76StAlBEjXCn EMJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8JBysDH3gdIhIID7hbG0vNGcorVxBHvqkKAA5hy08ZQ=; b=bG1a12VyCH4Samj4S4/aSujMsHItQv9CxbMVLq//9oMH4YeaTF9l1wTkQkb9Ot7B/V hsxz2oxabucOF7RFlQBo47OG9a64gMUi09xx0EjfECbBJWm4WcVCR9gad1EMldAaWv7p 8TdCMjJajypcpnfUg2YjNnmpxt0V47F7rRTfpOijOdKqhjSVIzflc6TgnXkF1GctbN0Z s+3RnomAP/lnPp9H8xl3u2cmxVqQbn0zE6Tf4L1VEtfSRH5P6nF1QxVeBw0G4hKVg9RZ 4UN8N5T3f1qSEpmxoTc3bNAfmfY09WsIfSECVDRHv3AdKioZggcaDvuRlufG5u66XGmb onVg== X-Gm-Message-State: ABuFfohzzOLoqRiCWfRv9QQRYOTQ92vCsWSMQOz3tQLrU8fYlySDRKGC BCrD+r0LGrrUqa6ZOXKAIp4= X-Google-Smtp-Source: ACcGV60tLnlenb7tLppXQlRfjkQV6moblp4jm8RSJMKLlSfpwEU4qY+pHd4lk1ruPCgASmWF7HwRXA== X-Received: by 2002:a5d:61ca:: with SMTP id q10-v6mr22913925wrv.33.1539214497536; Wed, 10 Oct 2018 16:34:57 -0700 (PDT) Received: from localhost.localdomain ([141.226.14.107]) by smtp.gmail.com with ESMTPSA id h2-v6sm21768484wrs.34.2018.10.10.16.34.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Oct 2018 16:34:57 -0700 (PDT) From: Amir Goldstein To: Cyril Hrubis Date: Thu, 11 Oct 2018 02:34:41 +0300 Message-Id: <20181010233441.5337-7-amir73il@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181010233441.5337-1-amir73il@gmail.com> References: <20181010233441.5337-1-amir73il@gmail.com> X-Virus-Scanned: clamav-milter 0.99.2 at in-3.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-3.smtp.seeweb.it Cc: linux-unionfs@vger.kernel.org, ltp@lists.linux.it, Miklos Szeredi Subject: [LTP] [PATCH v3 6/6] syscalls/readahead02: fail test if readahead did not use any cache X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" The heuristic of failing the test only if not saving any io has false negatives with overlayfs readahead() bug, but readahead() with overlayfs always warns on "using less cache then expected", when actually, it is using no cache at all. Add another condition to fail the test if readahead did not use any cache at all, which always detected the overlayfs bug. Signed-off-by: Amir Goldstein Acked-by: Jan Stancek --- testcases/kernel/syscalls/readahead/readahead02.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testcases/kernel/syscalls/readahead/readahead02.c b/testcases/kernel/syscalls/readahead/readahead02.c index d5cc7677b..657461905 100644 --- a/testcases/kernel/syscalls/readahead/readahead02.c +++ b/testcases/kernel/syscalls/readahead/readahead02.c @@ -346,6 +346,8 @@ static void test_readahead(unsigned int n) */ if (cached_ra * 1024 > testfile_size / 2) tst_res(TPASS, "using cache as expected"); + else if (!cached_ra) + tst_res(TFAIL, "readahead failed to use any cache"); else tst_res(TWARN, "using less cache than expected"); } else {