| Message ID | 20180610101309.8201-1-pvorel@suse.cz |
|---|---|
| State | Accepted |
| Delegated to: | Petr Vorel |
| Headers | show |
| Series | [1/1] network.sh: Cleanup netpan logs | expand |
Hi, > network.sh script doesn't delete it's logs, which can lead to fill /tmp. > Remove these files, which unify behavior with runltp and runltplite.sh > (just don't use trap to force remove on INT). ... > testscripts/network.sh | 2 ++ ... > @@ -121,3 +121,5 @@ if [ $? -eq "0" ]; then > else > echo ltp-pan reported FAIL > fi > + > +rm -rf $TMPDIR I suppose there is no reason to keep ltp-net logs, that it was left by accident. This patch keeps /tmp/netpan.log, but that's just one file. Kind regards, Petr
On 10.06.2018 13:13, Petr Vorel wrote: > network.sh script doesn't delete it's logs, which can lead to fill /tmp. > Remove these files, which unify behavior with runltp and runltplite.sh > (just don't use trap to force remove on INT). > > Signed-off-by: Petr Vorel <pvorel@suse.cz> Acked-by: Alexey Kodanev <alexey.kodanev@oracle.com>
Hi Alexey, > On 10.06.2018 13:13, Petr Vorel wrote: > > network.sh script doesn't delete it's logs, which can lead to fill /tmp. > > Remove these files, which unify behavior with runltp and runltplite.sh > > (just don't use trap to force remove on INT). > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > Acked-by: Alexey Kodanev <alexey.kodanev@oracle.com> Thanks, pushed! Kind regards, Petr
diff --git a/testscripts/network.sh b/testscripts/network.sh index c946e4d86..78257d8db 100755 --- a/testscripts/network.sh +++ b/testscripts/network.sh @@ -121,3 +121,5 @@ if [ $? -eq "0" ]; then else echo ltp-pan reported FAIL fi + +rm -rf $TMPDIR
network.sh script doesn't delete it's logs, which can lead to fill /tmp. Remove these files, which unify behavior with runltp and runltplite.sh (just don't use trap to force remove on INT). Signed-off-by: Petr Vorel <pvorel@suse.cz> --- testscripts/network.sh | 2 ++ 1 file changed, 2 insertions(+)