From patchwork Wed Mar 14 10:40:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Palethorpe X-Patchwork-Id: 885663 X-Patchwork-Delegate: akodanev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.com Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 401Svg56znz9sV3 for ; Wed, 14 Mar 2018 21:41:48 +1100 (AEDT) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 8A7AA3E76E1 for ; Wed, 14 Mar 2018 11:41:39 +0100 (CET) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) by picard.linux.it (Postfix) with ESMTP id 94DF33E76D3 for ; Wed, 14 Mar 2018 11:41:36 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 4FEE3201512 for ; Wed, 14 Mar 2018 11:41:35 +0100 (CET) Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 20989AD9E; Wed, 14 Mar 2018 10:41:33 +0000 (UTC) From: Richard Palethorpe To: ltp@lists.linux.it Date: Wed, 14 Mar 2018 11:40:59 +0100 Message-Id: <20180314104059.28051-1-rpalethorpe@suse.com> X-Mailer: git-send-email 2.16.2 X-Virus-Scanned: clamav-milter 0.99.2 at in-7.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=-0.0 required=7.0 tests=SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-7.smtp.seeweb.it Cc: pvorel@suse.com, Richard Palethorpe Subject: [LTP] [PATCH] lib: fix length check in safe_sendmsg X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" It appears that we only check the len parameter against the return value if the len parameter is zero. Signed-off-by: Richard Palethorpe --- lib/safe_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/safe_net.c b/lib/safe_net.c index 9ea9d2b42..96216ee69 100644 --- a/lib/safe_net.c +++ b/lib/safe_net.c @@ -200,7 +200,7 @@ ssize_t safe_sendmsg(const char *file, const int lineno, size_t len, file, lineno, sockfd, msg, flags); } - if (!len && (size_t)rval != len) { + if (len && (size_t)rval != len) { tst_brkm(TBROK, NULL, "%s:%d: sendmsg(%d, %p, %d) ret(%zd) != len(%zu)", file, lineno, sockfd, msg, flags, rval, len);