diff mbox series

[v2,1/2] syscalls/geteuid01: Convert into new api

Message ID 1688637954-17765-1-git-send-email-xuyang2018.jy@fujitsu.com
State Accepted
Headers show
Series [v2,1/2] syscalls/geteuid01: Convert into new api | expand

Commit Message

Yang Xu \(Fujitsu\) July 6, 2023, 10:05 a.m. UTC 
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
 testcases/kernel/syscalls/geteuid/geteuid01.c | 91 +++++----------------------
 1 file changed, 14 insertions(+), 77 deletions(-)

Comments

Petr Vorel July 10, 2023, 1:46 p.m. UTC | #1 
Hi Xu,

> + * Copyright (c) Linux Test Project, 2003-2023
> + * AUTHOR: William Roske, Dave Fenne
Very very nit: s/AUTHOR/Author/

Also, in the subject in both commits: s/api/API/

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr
Yang Xu \(Fujitsu\) July 17, 2023, 2:56 p.m. UTC | #2 
Hi Petr

> Hi Xu,
> 
>> + * Copyright (c) Linux Test Project, 2003-2023
>> + * AUTHOR: William Roske, Dave Fenne
> Very very nit: s/AUTHOR/Author/
> 
> Also, in the subject in both commits: s/api/API/
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>

Thanks for your review.

I merged this patch set and modified getuid01 to origin gpl-2.0-only.

But  It seems all of uid/gid case miss to use COMPAT_TST_16_H:= 1 in 
Makefile except syscalls/setuid.

I search the history, it seems related to  a bugfix[1] when 
touch/modify/create fiel in syscall/utils.

[1]https://github.com/linux-test-project/ltp/commit/631d16671d876524588320ee71fd23fe22750307

Best Regards
Yang Xu
> 
> Kind regards,
> Petr
Petr Vorel July 18, 2023, 10:02 a.m. UTC | #3 
Hi Xu,

> Hi Petr

> > Hi Xu,

> >> + * Copyright (c) Linux Test Project, 2003-2023
> >> + * AUTHOR: William Roske, Dave Fenne
> > Very very nit: s/AUTHOR/Author/

> > Also, in the subject in both commits: s/api/API/

> > Reviewed-by: Petr Vorel <pvorel@suse.cz>

> Thanks for your review.

> I merged this patch set and modified getuid01 to origin gpl-2.0-only.

> But  It seems all of uid/gid case miss to use COMPAT_TST_16_H:= 1 in 
> Makefile except syscalls/setuid.

> I search the history, it seems related to  a bugfix[1] when 
> touch/modify/create fiel in syscall/utils.

> [1]https://github.com/linux-test-project/ltp/commit/631d16671d876524588320ee71fd23fe22750307

Good point. I send a patch which switches the logic (old tests have variable):

https://patchwork.ozlabs.org/project/ltp/patch/20230718100050.1162482-1-pvorel@suse.cz/

Kind regards,
Petr

> Best Regards
> Yang Xu

> > Kind regards,
> > Petr
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/geteuid/geteuid01.c b/testcases/kernel/syscalls/geteuid/geteuid01.c
index d02fb0a..0df8fae 100644
--- a/testcases/kernel/syscalls/geteuid/geteuid01.c
+++ b/testcases/kernel/syscalls/geteuid/geteuid01.c
@@ -1,87 +1,24 @@ 
+//SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it would be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
- *
- * Further, this software is distributed without any warranty that it is
- * free of the rightful claim of any third person regarding infringement
- * or the like.  Any license provided herein, whether implied or
- * otherwise, applies only to this software file.  Patent licenses, if
- * any, provided herein do not apply to combinations of this program with
- * other software, or any other product whatsoever.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
- *
- * Contact information: Silicon Graphics, Inc., 1600 Amphitheatre Pkwy,
- * Mountain View, CA  94043, or:
- *
- * http://www.sgi.com
- *
- * For further information regarding this notice, see:
- *
- * http://oss.sgi.com/projects/GenInfo/NoticeExplan/
- *
+ * Copyright (c) Linux Test Project, 2003-2023
+ * AUTHOR: William Roske, Dave Fenne
  */
 
-/*
- *    AUTHOR		: William Roske
- *    CO-PILOT		: Dave Fenner
+/*\
+ *[Description]
+ *
+ * Check the basic functionality of the geteuid() system call.
  */
 
-#include <sys/types.h>
-#include <errno.h>
-#include <string.h>
-#include <signal.h>
-
-#include "test.h"
-#include "compat_16.h"
-
-static void setup(void);
-static void cleanup(void);
-
-TCID_DEFINE(geteuid01);
-int TST_TOTAL = 1;
+#include "tst_test.h"
+#include "compat_tst_16.h"
 
-int main(int ac, char **av)
+static void verify_geteuid(void)
 {
-	int lc;
-
-	tst_parse_opts(ac, av, NULL, NULL);
-
-	setup();
-
-	for (lc = 0; TEST_LOOPING(lc); lc++) {
-
-		tst_count = 0;
-
-		TEST(GETEUID(cleanup));
-
-		if (TEST_RETURN < 0) {
-			tst_resm(TFAIL | TTERRNO, "geteuid failed");
-			continue;	/* next loop for MTKERNEL */
-		}
-
-		tst_resm(TPASS, "geteuid returned %ld", TEST_RETURN);
-	}
-
-	cleanup();
-	tst_exit();
-}
-
-static void setup(void)
-{
-	tst_sig(NOFORK, DEF_HANDLER, cleanup);
-	TEST_PAUSE;
+	TST_EXP_POSITIVE(GETEUID(), "geteuid()");
 }
 
-static void cleanup(void)
-{
-}
+static struct tst_test test = {
+	.test_all = verify_geteuid,
+};