From patchwork Tue Jul 12 06:46:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongchen Zhang X-Patchwork-Id: 1655201 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lhrrs0HjRz9sB4 for ; Tue, 12 Jul 2022 16:46:52 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 69B873CA178 for ; Tue, 12 Jul 2022 08:46:50 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 0762B3C65EF for ; Tue, 12 Jul 2022 08:46:49 +0200 (CEST) Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by in-7.smtp.seeweb.it (Postfix) with ESMTP id E26842009B0 for ; Tue, 12 Jul 2022 08:46:47 +0200 (CEST) Received: from localhost.localdomain.localdomain (unknown [10.2.5.46]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dxf9HSGM1iALoYAA--.15346S2; Tue, 12 Jul 2022 14:46:45 +0800 (CST) From: Hongchen Zhang To: Petr Vorel Date: Tue, 12 Jul 2022 14:46:40 +0800 Message-Id: <1657608400-6497-1-git-send-email-zhanghongchen@loongson.cn> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: X-CM-TRANSID: AQAAf9Dxf9HSGM1iALoYAA--.15346S2 X-Coremail-Antispam: 1UD129KBjvJXoWxAF45Ar4DArW8trW3Xr1rCrg_yoW5GFy3pF ya93yjkFZ7Wr1UAr47Ars5Gr1rCF97Xr1jkr4rAr4xur9Fk3s8Xa1jvF10vF1UKr47GryU Ar4rC3Z5W3WDAF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvq14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1lc2xSY4AK6svPMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI 8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AK xVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI 8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Zr0_Wr1UMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0x ZFpf9x0JUDpnQUUUUU= X-CM-SenderInfo: x2kd0w5krqwupkhqwqxorr0wxvrqhubq/ X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=-0.0 required=7.0 tests=SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on in-7.smtp.seeweb.it Subject: [LTP] [PATCH v2] rpc01: fix variable not initialized X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libtirpc-devel@lists.sourceforge.net, ltp@lists.linux.it, Steve Dickson , Hongchen Zhang MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" when error occurred in function callrpc/clnt_call, return_buffer may be leaved not initialized. As Petr said, we should check the return value before retrieve the return_buffer->data. Change do_compare's parameter from char * to struct data * to fix it. Signed-off-by: Hongchen Zhang --- testcases/network/rpc/basic_tests/rpc01/rpc1.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/testcases/network/rpc/basic_tests/rpc01/rpc1.c b/testcases/network/rpc/basic_tests/rpc01/rpc1.c index bc9f35b..8ef0e4d 100644 --- a/testcases/network/rpc/basic_tests/rpc01/rpc1.c +++ b/testcases/network/rpc/basic_tests/rpc01/rpc1.c @@ -18,7 +18,8 @@ char *file_name = NULL; char host_name[100]; long host_address; -void do_compare(int, char *, struct data *, char *); +void do_compare(int rpc_rc, char *msg, struct data *buffer, + struct data *ret_buffer); void usage_error(char *program_name); int main(int argc, char *argv[]) @@ -128,7 +129,7 @@ int main(int argc, char *argv[]) rc = callrpc(server, program, version, 1, (xdrproc_t)xdr_send_data, (char *)&buffer, (xdrproc_t)xdr_receive_data, (char *)&return_buffer); - do_compare(rc, "callrpc", &buffer, return_buffer->data); + do_compare(rc, "callrpc", &buffer, return_buffer); server_sin.sin_port = 0; sock = RPC_ANYSOCK; @@ -145,7 +146,7 @@ int main(int argc, char *argv[]) (char *)&buffer, (xdrproc_t)xdr_receive_data, (char *)&return_buffer, timeout); clnt_destroy(clnt); - do_compare(rc, "udp transport", &buffer, return_buffer->data); + do_compare(rc, "udp transport", &buffer, return_buffer); server_sin.sin_port = 0; sock = RPC_ANYSOCK; @@ -160,12 +161,13 @@ int main(int argc, char *argv[]) (char *)&buffer, (xdrproc_t)xdr_receive_data, (char *)&return_buffer, timeout); clnt_destroy(clnt); - do_compare(rc, "tcp transport", &buffer, return_buffer->data); + do_compare(rc, "tcp transport", &buffer, return_buffer); exit(0); } -void do_compare(int rpc_rc, char *msg, struct data *buffer, char *ret_data) +void do_compare(int rpc_rc, char *msg, struct data *buffer, + struct data *ret_buffer) { int rc; @@ -175,7 +177,7 @@ void do_compare(int rpc_rc, char *msg, struct data *buffer, char *ret_data) printf("\n"); exit(1); } - rc = memcmp(buffer->data, ret_data, buffer->data_length); + rc = memcmp(buffer->data, ret_buffer->data, buffer->data_length); if (rc) { printf("Data compare for %s returned %d\n", msg, rc); exit(1);