| Message ID | 1645459842-1609-1-git-send-email-daisl.fnst@fujitsu.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | lapi/fsmount.h: remove useless sys/mount.h | expand |
Hi Dai, Viresh, all, [ Cc: Viresh, as he's the author ] > Signed-off-by: Dai Shili <daisl.fnst@fujitsu.com> > --- > include/lapi/fsmount.h | 1 - > 1 file changed, 1 deletion(-) > diff --git a/include/lapi/fsmount.h b/include/lapi/fsmount.h > index fa25306..eb98c97 100644 > --- a/include/lapi/fsmount.h > +++ b/include/lapi/fsmount.h > @@ -7,7 +7,6 @@ > #ifndef LAPI_FSMOUNT_H__ > #define LAPI_FSMOUNT_H__ > -#include <sys/mount.h> indeed now is sys/mount.h useless, but we're not sure if there is no wrapper for new syscalls (e.g. fsopen, fsconfig, fspick, move_mount, ...) in any libc in the future. Because we have configure checks for these functions. @Viresh, was this the reason why you added <sys/mount.h> ? Kind regards, Petr > #include <sys/syscall.h> > #include <sys/types.h>
On 21-02-22, 19:04, Petr Vorel wrote: > Hi Dai, Viresh, all, > > [ Cc: Viresh, as he's the author ] > > > Signed-off-by: Dai Shili <daisl.fnst@fujitsu.com> > > --- > > include/lapi/fsmount.h | 1 - > > 1 file changed, 1 deletion(-) > > > diff --git a/include/lapi/fsmount.h b/include/lapi/fsmount.h > > index fa25306..eb98c97 100644 > > --- a/include/lapi/fsmount.h > > +++ b/include/lapi/fsmount.h > > @@ -7,7 +7,6 @@ > > #ifndef LAPI_FSMOUNT_H__ > > #define LAPI_FSMOUNT_H__ > > > -#include <sys/mount.h> > > indeed now is sys/mount.h useless, but we're not sure if there is no wrapper > for new syscalls (e.g. fsopen, fsconfig, fspick, move_mount, ...) in any libc in > the future. Because we have configure checks for these functions. > @Viresh, was this the reason why you added <sys/mount.h> ? Right. Once the libc has the prototypes of these routines, most of fsmount.h will become useless and sys/mount.h is the one that is going to be used.
diff --git a/include/lapi/fsmount.h b/include/lapi/fsmount.h index fa25306..eb98c97 100644 --- a/include/lapi/fsmount.h +++ b/include/lapi/fsmount.h @@ -7,7 +7,6 @@ #ifndef LAPI_FSMOUNT_H__ #define LAPI_FSMOUNT_H__ -#include <sys/mount.h> #include <sys/syscall.h> #include <sys/types.h>
Signed-off-by: Dai Shili <daisl.fnst@fujitsu.com> --- include/lapi/fsmount.h | 1 - 1 file changed, 1 deletion(-)