diff mbox series

[v2] route{4, 6}-rmmod: Declare variables before using them

Message ID 1599705028-12889-1-git-send-email-zhufy.jy@cn.fujitsu.com
State Accepted
Headers show
Series [v2] route{4, 6}-rmmod: Declare variables before using them | expand

Commit Message

Feiyu Zhu Sept. 10, 2020, 2:30 a.m. UTC
When running route4-rmmod case, it reports the following error:
/opt/ltp/testcases/bin/route4-rmmod: line 100: lhost_module: unbound variable.

It fails because "set -u" is used in .testcases/lib/cmdlib.sh and
"set -u" treats unset variables and parameters as errors.

Reviewed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Feiyu Zhu <zhufy.jy@cn.fujitsu.com>
---
 testcases/network/stress/route/route4-rmmod | 3 +++
 testcases/network/stress/route/route6-rmmod | 3 +++
 2 files changed, 6 insertions(+)

Comments

Petr Vorel Sept. 10, 2020, 8:54 a.m. UTC | #1
Hi Feiyu,

> When running route4-rmmod case, it reports the following error:
> /opt/ltp/testcases/bin/route4-rmmod: line 100: lhost_module: unbound variable.

> It fails because "set -u" is used in .testcases/lib/cmdlib.sh and
> "set -u" treats unset variables and parameters as errors.

Thanks a lot for update, merged.

Kind regards,
Petr
diff mbox series

Patch

diff --git a/testcases/network/stress/route/route4-rmmod b/testcases/network/stress/route/route4-rmmod
index 5947bb3..7aa1958 100644
--- a/testcases/network/stress/route/route4-rmmod
+++ b/testcases/network/stress/route/route4-rmmod
@@ -125,6 +125,9 @@  do_setup()
 	exit $TST_TOTAL
     fi
 
+    # The module name of the interface at the local host
+    lhost_module=
+
     # Make sure to clean up
     do_cleanup
 
diff --git a/testcases/network/stress/route/route6-rmmod b/testcases/network/stress/route/route6-rmmod
index 73f26f2..765a57a 100644
--- a/testcases/network/stress/route/route6-rmmod
+++ b/testcases/network/stress/route/route6-rmmod
@@ -121,6 +121,9 @@  do_setup()
 	exit $TST_TOTAL
     fi
 
+    # The module name of the interface at the local host
+    lhost_module=
+
     # Make sure to clean up
     do_cleanup