| Message ID | 1598339667-24948-1-git-send-email-xuyang2018.jy@cn.fujitsu.com |
|---|---|
| State | Deferred |
| Headers | show |
| Series | [v2] travis: Use centos:7 instead of centos:6 | expand |
On Tue, Aug 25, 2020 at 3:14 PM Yang Xu <xuyang2018.jy@cn.fujitsu.com> wrote: > I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on > centos7. > It is more friendly for centos7 user and more meaningful. centos6 is > outdated > and we should drop it. > > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> > Acked-by: Li Wang <liwang@redhat.com> > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index e8e3189af..3c5ff99b7 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -44,7 +44,7 @@ matrix: > compiler: clang > > - os: linux > - env: DISTRO=centos:6 TREE=out > + env: DISTRO=centos:7 TREE=out > compiler: gcc > > - os: linux > -- > 2.23.0 > > > > > -- > Mailing list info: https://lists.linux.it/listinfo/ltp > >
Hi Li, Petr Does have anything block this patch? Or, we should listen some advise from Jan and Cyril? ps: Also, ALG_SET_AEAD_ASSOCLEN undefined error patch needs to be reviewed. Best Regards Yang Xu > > > On Tue, Aug 25, 2020 at 3:14 PM Yang Xu <xuyang2018.jy@cn.fujitsu.com > <mailto:xuyang2018.jy@cn.fujitsu.com>> wrote: > > I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error > on centos7. > It is more friendly for centos7 user and more meaningful. centos6 is > outdated > and we should drop it. > > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com > <mailto:xuyang2018.jy@cn.fujitsu.com>> > > Acked-by: Li Wang <liwang@redhat.com <mailto:liwang@redhat.com>> > > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index e8e3189af..3c5ff99b7 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -44,7 +44,7 @@ matrix: > compiler: clang > > - os: linux > - env: DISTRO=centos:6 TREE=out > + env: DISTRO=centos:7 TREE=out > compiler: gcc > > - os: linux > -- > 2.23.0 > > > > > -- > Mailing list info: https://lists.linux.it/listinfo/ltp > > > > -- > Regards, > Li Wang
Hi Xu, Sorry for the delay. I guess many Developers(European or North America) are busy with the LPC(Linux Plumbers Conference) recently. please keep patience:). Btw, there is a new build error on CentOS7(seems unrelated to your patch): /usr/src/ltp/lib/tst_af_alg.c:205:21: error: 'ALG_SET_AEAD_ASSOCLEN' undeclared (first use in this function) 2084 cmsg->cmsg_type = ALG_SET_AEAD_ASSOCLEN; https://travis-ci.com/github/wangli5665/ltp/jobs/378677988 On Fri, Aug 28, 2020 at 11:22 AM Yang Xu <xuyang2018.jy@cn.fujitsu.com> wrote: > Hi Li, Petr > > Does have anything block this patch? Or, we should listen some advise > from Jan and Cyril? > > ps: Also, ALG_SET_AEAD_ASSOCLEN undefined error patch needs to be reviewed. > > Best Regards > Yang Xu > > > > > > On Tue, Aug 25, 2020 at 3:14 PM Yang Xu <xuyang2018.jy@cn.fujitsu.com > > <mailto:xuyang2018.jy@cn.fujitsu.com>> wrote: > > > > I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error > > on centos7. > > It is more friendly for centos7 user and more meaningful. centos6 is > > outdated > > and we should drop it. > > > > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com > > <mailto:xuyang2018.jy@cn.fujitsu.com>> > > > > Acked-by: Li Wang <liwang@redhat.com <mailto:liwang@redhat.com>> > > > > --- > > .travis.yml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index e8e3189af..3c5ff99b7 100644 > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -44,7 +44,7 @@ matrix: > > compiler: clang > > > > - os: linux > > - env: DISTRO=centos:6 TREE=out > > + env: DISTRO=centos:7 TREE=out > > compiler: gcc > > > > - os: linux > > -- > > 2.23.0 > > > > > > > > > > -- > > Mailing list info: https://lists.linux.it/listinfo/ltp > > > > > > > > -- > > Regards, > > Li Wang > > >
On Fri, Aug 28, 2020 at 2:40 PM Li Wang <liwang@redhat.com> wrote: > Hi Xu, > > Sorry for the delay. I guess many Developers(European or North > America) are busy with the LPC(Linux Plumbers Conference) recently. please > keep patience:). > > Btw, there is a new build error on CentOS7(seems unrelated to your patch): > > /usr/src/ltp/lib/tst_af_alg.c:205:21: error: 'ALG_SET_AEAD_ASSOCLEN' > undeclared (first use in this function) > 2084 cmsg->cmsg_type = ALG_SET_AEAD_ASSOCLEN; > Ah, seems you have sent a patch for that, I will help to review soon. http://lists.linux.it/pipermail/ltp/2020-August/018651.html
Hi, > On Fri, Aug 28, 2020 at 2:40 PM Li Wang <liwang@redhat.com> wrote: > > Hi Xu, > > Sorry for the delay. I guess many Developers(European or North > > America) are busy with the LPC(Linux Plumbers Conference) recently. please > > keep patience:). +1 :) > > Btw, there is a new build error on CentOS7(seems unrelated to your patch): > > /usr/src/ltp/lib/tst_af_alg.c:205:21: error: 'ALG_SET_AEAD_ASSOCLEN' > > undeclared (first use in this function) > > 2084 cmsg->cmsg_type = ALG_SET_AEAD_ASSOCLEN; > Ah, seems you have sent a patch for that, I will help to review soon. > http://lists.linux.it/pipermail/ltp/2020-August/018651.html Looking into that. Kind regards, Petr
> I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7. > It is more friendly for centos7 user and more meaningful. centos6 is outdated > and we should drop it. > Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> Reviewed-by: Petr Vorel <pvorel@suse.cz> Kind regards, Petr > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/.travis.yml b/.travis.yml > index e8e3189af..3c5ff99b7 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -44,7 +44,7 @@ matrix: > compiler: clang > - os: linux > - env: DISTRO=centos:6 TREE=out > + env: DISTRO=centos:7 TREE=out > compiler: gcc > - os: linux
Hi! > Does have anything block this patch? Or, we should listen some advise > from Jan and Cyril? I would be for dropping centos 6 (if nobody objects) after next release, which will happen in a couple of weeks anyways. So for now on I would be for adding centos 7, so that the next release compiles cleanly both on centos 6 and 7. Then we can work on our minimal requirements and drop obsolete code.
Hi, > Hi! > > Does have anything block this patch? Or, we should listen some advise > > from Jan and Cyril? > I would be for dropping centos 6 (if nobody objects) after next release, > which will happen in a couple of weeks anyways. > So for now on I would be for adding centos 7, so that the next release > compiles cleanly both on centos 6 and 7. > Then we can work on our minimal requirements and drop obsolete code. Make sense. So I merged the original patch. Kind regards, Petr
diff --git a/.travis.yml b/.travis.yml index e8e3189af..3c5ff99b7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -44,7 +44,7 @@ matrix: compiler: clang - os: linux - env: DISTRO=centos:6 TREE=out + env: DISTRO=centos:7 TREE=out compiler: gcc - os: linux
I have this idea when I meet ALG_SET_AEAD_ASSOCLEN undefined error on centos7. It is more friendly for centos7 user and more meaningful. centos6 is outdated and we should drop it. Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)