open_posix_testsuite: Enable the testsuite

Enable open posix testsuite compilation by default

Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 testcases/Makefile | 4 ----
 1 file changed, 4 deletions(-)

--
2.6.2

Hi Zou & Xiao,

Do we really need to enable the open_posix_testsuite explicitly? By
default, LTP uses "--with-open-posix-testsuite" as the configure parameter
to enabling it, is that work for you?

i.e you can include the open_posix_testsuite build by perform `./build.sh`

On Tue, Mar 17, 2020 at 3:27 PM Zou Wei <zou_wei@huawei.com> wrote:

> Enable open posix testsuite compilation by default
>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  testcases/Makefile | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/testcases/Makefile b/testcases/Makefile
> index b04e630..ae1cafc 100644
> --- a/testcases/Makefile
> +++ b/testcases/Makefile
> @@ -30,10 +30,6 @@ include $(top_srcdir)/include/mk/env_pre.mk
>  #    run).
>  FILTER_OUT_DIRS                := kdump
>
> -ifneq ($(WITH_OPEN_POSIX_TESTSUITE),yes)
> -FILTER_OUT_DIRS                += open_posix_testsuite
> -endif
> -
>  ifneq ($(WITH_REALTIME_TESTSUITE),yes)
>  FILTER_OUT_DIRS                += realtime
>  endif
> --
> 2.6.2
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>

On 2020/3/17 15:55, Li Wang wrote:
> Hi Zou & Xiao,
>
> Do we really need to enable the open_posix_testsuite explicitly? By
> default, LTP uses "--with-open-posix-testsuite" as the configure
> parameter to enabling it, is that work for you?
Hi Li,

Agreed.  We don't need to enable the open_posix_testsuite unconditionally.

We can enable open_posix_testsuite by ./configure 
--with-open-posix-testsuite or ./build.sh.

Thanks,
Xiao Yang
>
> i.e you can include the open_posix_testsuite build by perform `./build.sh`

On Tue, Mar 17, 2020 at 6:43 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > Do we really need to enable the open_posix_testsuite explicitly? By
> > default, LTP uses "--with-open-posix-testsuite" as the configure
> parameter
> > to enabling it, is that work for you?
>
> Even if we wanted to enable openposix by default, which may be a good
> idea, we should change the default in configure.ac instead with:
>

Yes, your method looks better. But I'd suggest giving more time on bug
fixing before enabling open_posix_testsuit explicitly, other than
publishing that with many build issues. Seems Zou and Xu are working on
this part recently, that would be appreciated if more patches work out.

NAK.

This will build the suite on the build host, which includes a number of build time tests, which will slow down hosts and 

It’s better to flip the default in configure, but I think the build machinery needs to be reworked so runtime tests and build and installed and build time tests are just installed.

-Enji

> On Mar 17, 2020, at 00:27, Zou Wei <zou_wei@huawei.com> wrote:
> 
> Enable open posix testsuite compilation by default
> 
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> testcases/Makefile | 4 ----
> 1 file changed, 4 deletions(-)
> 
> diff --git a/testcases/Makefile b/testcases/Makefile
> index b04e630..ae1cafc 100644
> --- a/testcases/Makefile
> +++ b/testcases/Makefile
> @@ -30,10 +30,6 @@ include $(top_srcdir)/include/mk/env_pre.mk
> #    run).
> FILTER_OUT_DIRS        := kdump
> 
> -ifneq ($(WITH_OPEN_POSIX_TESTSUITE),yes)
> -FILTER_OUT_DIRS        += open_posix_testsuite
> -endif
> -
> ifneq ($(WITH_REALTIME_TESTSUITE),yes)
> FILTER_OUT_DIRS        += realtime
> endif
> --
> 2.6.2
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

Hi!
> Do we really need to enable the open_posix_testsuite explicitly? By
> default, LTP uses "--with-open-posix-testsuite" as the configure parameter
> to enabling it, is that work for you?

Even if we wanted to enable openposix by default, which may be a good
idea, we should change the default in configure.ac instead with:

diff --git a/configure.ac b/configure.ac
index c9ec39fce..0f2488617 100644
--- a/configure.ac
+++ b/configure.ac
@@ -256,7 +256,7 @@ AC_ARG_WITH([open-posix-testsuite],
   [AC_HELP_STRING([--with-open-posix-testsuite],
     [compile and install the open posix testsuite])],
   [with_open_posix_testsuite=$withval],
-  [with_open_posix_testsuite=no]
+  [with_open_posix_testsuite=yes]
 )
 if test "x$with_open_posix_testsuite" = xyes; then
     AC_SUBST([WITH_OPEN_POSIX_TESTSUITE],["yes"])