From patchwork Thu Apr 5 10:56:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Kodanev X-Patchwork-Id: 895347 X-Patchwork-Delegate: akodanev@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="c4cNS5kf"; dkim-atps=neutral Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40H00G6WjCz9s1s for ; Thu, 5 Apr 2018 20:47:42 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 1D5643E76D0 for ; Thu, 5 Apr 2018 12:47:37 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [IPv6:2001:4b78:1:20::2]) by picard.linux.it (Postfix) with ESMTP id 3FACB3E76AB for ; Thu, 5 Apr 2018 12:47:31 +0200 (CEST) Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id EDE78601F40 for ; Thu, 5 Apr 2018 12:47:30 +0200 (CEST) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w35AiYVW161474 for ; Thu, 5 Apr 2018 10:47:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2017-10-26; bh=EyQ4oq74o8iEWb8YRXitFVX4PS0tUlKuS9hNQeJmliI=; b=c4cNS5kfmGxqpmahLquzb3ghkU4BdO2dSL+ioPSqU8OTZqiek0+MRUkG0r8LdRfp4v2I 7ovnNJGLAVbnfBrzNZFsZzM77JQfKtkVzjLLBrsZ2i1ynZEsmUJQZR71AUrsZXdoIg6E ldjjTRBne6OSui8QYOlTQyiZmyPHzi4UTNcjsG8HVYvUNGeJE7I1YuKk/n7dkI0gxkZo fIiLzHLCJz+720CCxhQt8beU8psOZjwmIME9QnK5FDPBdg5CdW1IGPtK2KrZzxH47Iog EwtEhaDxcqBl/rHFt9+Adn8v3dx9shxRzYUb7GNVqF4N1a69PSGL5zAPJMd/EDIxEEbJ Vg== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2120.oracle.com with ESMTP id 2h5jak009u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 05 Apr 2018 10:47:28 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w35AlSY0031367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 5 Apr 2018 10:47:28 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w35AlRWD018323 for ; Thu, 5 Apr 2018 10:47:28 GMT Received: from ak.ru.oracle.com (/10.162.80.29) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 05 Apr 2018 03:47:27 -0700 From: Alexey Kodanev To: ltp@lists.linux.it Date: Thu, 5 Apr 2018 13:56:51 +0300 Message-Id: <1522925812-17200-2-git-send-email-alexey.kodanev@oracle.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1522925812-17200-1-git-send-email-alexey.kodanev@oracle.com> References: <1522925812-17200-1-git-send-email-alexey.kodanev@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8853 signatures=668697 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=943 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804050107 X-Virus-Scanned: clamav-milter 0.99.2 at in-2.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-2.smtp.seeweb.it Subject: [LTP] [PATCH COMMITTED 2/3] netstress: fix partial checksum length for UDP-Lite protocol X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Check UDPLITE_RECV_CSCOV value for the possible minimum since it is calculated from the server message length parameter, i.e. it must cover the protocol header. Otherwise, if client sends the packet with the lesser checksum length, server will drop such packets. Fixes: 0bc572423473 ("netstress: support UDPLITE protocol") Signed-off-by: Alexey Kodanev --- testcases/network/netstress/netstress.c | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/testcases/network/netstress/netstress.c b/testcases/network/netstress/netstress.c index 72f4a40..971a673 100644 --- a/testcases/network/netstress/netstress.c +++ b/testcases/network/netstress/netstress.c @@ -165,13 +165,16 @@ static void init_socket_opts(int sd) SAFE_SETSOCKOPT_INT(sd, SOL_DCCP, DCCP_SOCKOPT_SERVICE, service_code); break; - case TYPE_UDP_LITE: + case TYPE_UDP_LITE: { + int cscov = init_srv_msg_len >> 1; + + if (cscov < 8) + cscov = 8; + tst_res(TINFO, "UDP-Lite send cscov is %d", cscov); /* set checksum for header and partially for payload */ - SAFE_SETSOCKOPT_INT(sd, SOL_UDPLITE, UDPLITE_SEND_CSCOV, - init_srv_msg_len >> 1); - SAFE_SETSOCKOPT_INT(sd, SOL_UDPLITE, UDPLITE_RECV_CSCOV, - init_srv_msg_len >> 2); - break; + SAFE_SETSOCKOPT_INT(sd, SOL_UDPLITE, UDPLITE_SEND_CSCOV, cscov); + SAFE_SETSOCKOPT_INT(sd, SOL_UDPLITE, UDPLITE_RECV_CSCOV, 8); + } break; } }