mbox series

[v2,0/3] Tests for fanotify on anonymous pipe

Message ID 20230716053530.1629416-1-amir73il@gmail.com
Headers show
Series Tests for fanotify on anonymous pipe | expand

Message

Amir Goldstein July 16, 2023, 5:35 a.m. UTC 
Petr,

This tests for a behavior that we consider broken since the dawn of
fanotify.

The fix was merged to v6.5-rc1.
I've already posted backport patches for kernels > v5.0 [1].
I am not planning to post backport patches for older kernels.

Even though the two new test cases do not use FAN_REPORT_FID,
fanotify14 requires FAN_REPORT_FID, so it is not going to run these
test cases on kernel < v5.1 anyway.

You suggested to wait for stable tree to apply the backports [2],
but this seems to be taking time.  Since I am going on vacation next
week, I am posting these tests, so you can merge them whenever you like.

Thanks,
Amir.

[1] https://lore.kernel.org/stable/20230710133205.1154168-1-amir73il@gmail.com/
[2] https://lore.kernel.org/ltp/20230710155006.GA659329@pevik/

Changes since v1:
- Fix build warnings of uninitialized struct members

Amir Goldstein (3):
  fanotify14: Use FAN_MARK_INODE semantic flag
  fanotify14: Use named initializers
  fanotify14: Test disallow sb/mount mark on anonymous pipe

 .../kernel/syscalls/fanotify/fanotify14.c     | 198 +++++++++++++-----
 1 file changed, 150 insertions(+), 48 deletions(-)

Comments

Petr Vorel July 17, 2023, 6:44 a.m. UTC | #1 
Hi Amir,

> Petr,

> This tests for a behavior that we consider broken since the dawn of
> fanotify.

> The fix was merged to v6.5-rc1.
> I've already posted backport patches for kernels > v5.0 [1].
> I am not planning to post backport patches for older kernels.

> Even though the two new test cases do not use FAN_REPORT_FID,
> fanotify14 requires FAN_REPORT_FID, so it is not going to run these
> test cases on kernel < v5.1 anyway.

> You suggested to wait for stable tree to apply the backports [2],
> but this seems to be taking time.  Since I am going on vacation next
> week, I am posting these tests, so you can merge them whenever you like.

I was probably too conservative, whole patchset merged, thank you!

Kind regards,
Petr