mbox series

[0/6] network/tcp_cc: add new tests bbr01 and bbr02

Message ID 1526903310-2833-1-git-send-email-alexey.kodanev@oracle.com
Headers show
Series network/tcp_cc: add new tests bbr01 and bbr02 | expand

Message

Alexey Kodanev May 21, 2018, 11:48 a.m. UTC 
The patches are adding two new tests for BBR congestion control
algorithm.

* bbr01 test is a simple one and similar to dctcp01 but not using
  ECN when emulating packet loss.

* bbr02 test, in addition to packet loss emulation with ECN, is using
  delay, reorder and corrupt features of 'tc'. And also iterates the
  different queueing disciplines.

The last test, I guess, should use TST_TEST_DATA for passing queueing
disciplines.

Alexey Kodanev (6):
  network: rename dcctp dir to tcp_cc
  dctcp01: convert to new API and move common code to a library
  network/tcp_cc/dctcp01: increase packet loss for dctcp
  network/tcp_cc/lib: add a function to set qdisc and txqueuelen
  network/tcp_cc: add new test bbr01
  network/tcp_cc: add new test bbr02

 runtest/net.features                   |    5 ++
 testcases/network/dctcp/Makefile       |   22 --------
 testcases/network/dctcp/dctcp01.sh     |   91 --------------------------------
 testcases/network/tcp_cc/Makefile      |   22 ++++++++
 testcases/network/tcp_cc/bbr01.sh      |   32 +++++++++++
 testcases/network/tcp_cc/bbr02.sh      |   45 ++++++++++++++++
 testcases/network/tcp_cc/dctcp01.sh    |   38 +++++++++++++
 testcases/network/tcp_cc/tcp_cc_lib.sh |   91 ++++++++++++++++++++++++++++++++
 8 files changed, 233 insertions(+), 113 deletions(-)
 delete mode 100644 testcases/network/dctcp/Makefile
 delete mode 100755 testcases/network/dctcp/dctcp01.sh
 create mode 100644 testcases/network/tcp_cc/Makefile
 create mode 100755 testcases/network/tcp_cc/bbr01.sh
 create mode 100755 testcases/network/tcp_cc/bbr02.sh
 create mode 100755 testcases/network/tcp_cc/dctcp01.sh
 create mode 100755 testcases/network/tcp_cc/tcp_cc_lib.sh

Comments

Petr Vorel May 24, 2018, 3:41 p.m. UTC | #1 
Hi Alexey,

> The patches are adding two new tests for BBR congestion control
> algorithm.

> * bbr01 test is a simple one and similar to dctcp01 but not using
>   ECN when emulating packet loss.

> * bbr02 test, in addition to packet loss emulation with ECN, is using
>   delay, reorder and corrupt features of 'tc'. And also iterates the
>   different queueing disciplines.
Whole patchset looks good to me. I hope to have deeper look tomorrow or on Monday (if you
don't merge it before).

> The last test, I guess, should use TST_TEST_DATA for passing queueing
> disciplines.
Yes.


Kind regards,
Petr