From patchwork Fri Apr 30 17:43:22 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Grant Likely X-Patchwork-Id: 51364 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id C4AD1B7F57 for ; Sat, 1 May 2010 03:44:01 +1000 (EST) Received: by ozlabs.org (Postfix) id 5FF6DB7D41; Sat, 1 May 2010 03:43:52 +1000 (EST) Delivered-To: linuxppc-dev@ozlabs.org Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.221.175]) by ozlabs.org (Postfix) with ESMTP id C8C56B7D40 for ; Sat, 1 May 2010 03:43:51 +1000 (EST) Received: by qyk5 with SMTP id 5so503950qyk.3 for ; Fri, 30 Apr 2010 10:43:49 -0700 (PDT) Received: by 10.224.59.222 with SMTP id m30mr2034167qah.40.1272649425626; Fri, 30 Apr 2010 10:43:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.84.12 with HTTP; Fri, 30 Apr 2010 10:43:22 -0700 (PDT) In-Reply-To: References: <4BDAF376.4030005@in.ibm.com> <4BDB12FB.5060806@in.ibm.com> From: Grant Likely Date: Fri, 30 Apr 2010 11:43:22 -0600 X-Google-Sender-Auth: f88ab60bf9b0441a Message-ID: Subject: Re: -next Apr 30: OOPS during eHEA driver initialization To: Sachin Sant Cc: Linux/PPC Development , "linux-next@vger.kernel.org" , Greg Kroah-Hartman , linux-kernel X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org On Fri, Apr 30, 2010 at 11:35 AM, Grant Likely wrote: > On Fri, Apr 30, 2010 at 11:27 AM, Sachin Sant wrote: >> Sachin Sant wrote: >>> >>> With today's next eHEA drivers fails to initialize. >> >> If i revert the following patch eHEA network interface is initialized >> properly. >> >> commit cebfe0b6709abdab997c1a00499d67efa32ee1f0 >> drivercore: Add of_match_table to the common device drivers > > That is an easy one to fix.  I'll get it updated today and send you the result. Let me know if this patch fixes it: Cheers, g. diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c index ce957a4..693b0e6 100644 --- a/arch/powerpc/kernel/ibmebus.c +++ b/arch/powerpc/kernel/ibmebus.c @@ -201,6 +201,9 @@ static int ibmebus_create_devices(const struct of_device_id *matches) int ibmebus_register_driver(struct of_platform_driver *drv) { + if (!drv->driver.of_match_table) + drv->driver.of_match_table = drv->match_table; + /* If the driver uses devices that ibmebus doesn't know, add them */ ibmebus_create_devices(drv->driver.of_match_table);