From patchwork Fri Jun 30 10:07:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Ellerman X-Patchwork-Id: 782740 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wzXKD3f7Wz9s9Y for ; Fri, 30 Jun 2017 20:08:00 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3wzXKD2lZ7zDr6x for ; Fri, 30 Jun 2017 20:08:00 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wzXJ80xL3zDr51 for ; Fri, 30 Jun 2017 20:07:04 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 3wzXJ75pyjz9sNX; Fri, 30 Jun 2017 20:07:03 +1000 (AEST) From: Michael Ellerman To: Eryu Guan Subject: Re: kworker with empty task->cpus_allowed (was Re: [v4.12-rc1 regression] mount ext4 fs results in kernel crash on PPC64le host) In-Reply-To: <20170629135919.GU23360@eguan.usersys.redhat.com> References: <20170628083237.GF23360@eguan.usersys.redhat.com> <20170629034122.GI23360@eguan.usersys.redhat.com> <20170629100533.GQ23360@eguan.usersys.redhat.com> <87efu39he0.fsf@concordia.ellerman.id.au> <20170629113933.GT23360@eguan.usersys.redhat.com> <878tkb9ewo.fsf@concordia.ellerman.id.au> <20170629135919.GU23360@eguan.usersys.redhat.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 30 Jun 2017 20:07:02 +1000 Message-ID: <8760fdrdq1.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tj@kernel.org, "open list:LINUX FOR POWERPC \(32-BIT AND 64-BIT\)" , liwan@redhat.com Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Eryu Guan writes: > > I have to update the patch a bit to make it compile. Sure. >> + WARN_ON(cpumask_empty(worker->task->cpus_allowed)); >> + WARN_ON(cpumask_empty(pool->attrs->cpumask)); > > Seems only the last two WARN_ON were triggered. OK thanks. Can you try this patch and see if it changes anything? (with the debug still applied). We've been trying to reproduce the bug here but haven't had any luck so far. cheers diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c index 4640f6d64f8b..b310ecc07e00 100644 --- a/arch/powerpc/kernel/setup_64.c +++ b/arch/powerpc/kernel/setup_64.c @@ -733,6 +733,8 @@ void __init setup_per_cpu_areas(void) for_each_possible_cpu(cpu) { __per_cpu_offset[cpu] = delta + pcpu_unit_offsets[cpu]; paca[cpu].data_offset = __per_cpu_offset[cpu]; + + set_cpu_numa_node(cpu, numa_cpu_lookup_table[cpu]); } } #endif