| Message ID | 5c2325bd-3e7b-0026-4c1a-65f32737a74a@maciej.szmigiero.name (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2,1/2] ASoC: fsl_ssi: only enable proper channel slots in AC'97 mode | expand |
On Wed, Nov 22, 2017 at 12:55:14AM +0100, Maciej S. Szmigiero wrote: > In AC'97 mode we configure and start SSI RX / TX on probe path via > a call to _fsl_ssi_set_dai_fmt() function. > We don't need to call this function again later and in fact don't want to > do it since this function temporarily sets STCR, SRCR and SCR to some > intermediate values. > > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> Acked-by: Nicolin Chen <nicoleotsuka@gmail.com> > --- > Changes from v1: The SACCST setup code was split out into a separate > commit. > > sound/soc/fsl/fsl_ssi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c > index 375aaaf6080d..70df6bf832df 100644 > --- a/sound/soc/fsl/fsl_ssi.c > +++ b/sound/soc/fsl/fsl_ssi.c > @@ -1116,6 +1116,9 @@ static int fsl_ssi_set_dai_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt) > { > struct fsl_ssi_private *ssi_private = snd_soc_dai_get_drvdata(cpu_dai); > > + if (fsl_ssi_is_ac97(ssi_private)) > + return 0; > + > return _fsl_ssi_set_dai_fmt(cpu_dai->dev, ssi_private, fmt); > } > >
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 375aaaf6080d..70df6bf832df 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1116,6 +1116,9 @@ static int fsl_ssi_set_dai_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt) { struct fsl_ssi_private *ssi_private = snd_soc_dai_get_drvdata(cpu_dai); + if (fsl_ssi_is_ac97(ssi_private)) + return 0; + return _fsl_ssi_set_dai_fmt(cpu_dai->dev, ssi_private, fmt); }
In AC'97 mode we configure and start SSI RX / TX on probe path via a call to _fsl_ssi_set_dai_fmt() function. We don't need to call this function again later and in fact don't want to do it since this function temporarily sets STCR, SRCR and SCR to some intermediate values. Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> --- Changes from v1: The SACCST setup code was split out into a separate commit. sound/soc/fsl/fsl_ssi.c | 3 +++ 1 file changed, 3 insertions(+)