diff mbox

[1/4] axonram: Delete an error message for a failed memory allocation in axon_ram_probe()

Message ID 31790d2a-26b4-54f5-e52d-5637be0b676f@users.sourceforge.net (mailing list archive)
State Accepted
Commit fdbb9457b4e1d3a6deb3325bba7616334f371be7
Headers show

Commit Message

SF Markus Elfring Aug. 3, 2017, 7:12 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 3 Aug 2017 19:49:18 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/powerpc/sysdev/axonram.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Michael Ellerman Sept. 1, 2017, 1:29 p.m. UTC | #1 
On Thu, 2017-08-03 at 19:12:50 UTC, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 3 Aug 2017 19:49:18 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Series applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/a1bddf3991573f3dff2762bfca5e11

cheers
SF Markus Elfring Sept. 1, 2017, 3:13 p.m. UTC | #2 
> Series applied to powerpc next, thanks.

Thanks for another positive feedback.

But I wonder how you can refer to the “series” when the forth update step
“Delete an unnecessary variable initialisation” contained a broken suggestion.


> https://git.kernel.org/powerpc/c/a1bddf3991573f3dff2762bfca5e11

This link seems to refer (only?) to the update step “Improve a size determination”.
How is the status for the other two change possibilities of this software module?

Regards,
Markus
diff mbox

Patch

diff --git a/arch/powerpc/sysdev/axonram.c b/arch/powerpc/sysdev/axonram.c
index 2799706106c6..b82d1b023a15 100644
--- a/arch/powerpc/sysdev/axonram.c
+++ b/arch/powerpc/sysdev/axonram.c
@@ -193,7 +193,6 @@  static int axon_ram_probe(struct platform_device *device)
 
 	bank = kzalloc(sizeof(struct axon_ram_bank), GFP_KERNEL);
 	if (bank == NULL) {
-		dev_err(&device->dev, "Out of memory\n");
 		rc = -ENOMEM;
 		goto failed;
 	}