diff mbox series

ocxl: Use pci_dev_id() to simplify the code

Message ID 20230811102039.17257-1-zhengzengkai@huawei.com (mailing list archive)
State Accepted
Commit 075a88d5eb2806712c64bed98c30b6890ec30311
Headers show
Series ocxl: Use pci_dev_id() to simplify the code | expand

Commit Message

Zheng Zengkai Aug. 11, 2023, 10:20 a.m. UTC
PCI core API pci_dev_id() can be used to get the BDF number for a pci
device. We don't need to compose it mannually. Use pci_dev_id() to
simplify the code a little bit.

Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
---
 arch/powerpc/platforms/powernv/ocxl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Donnellan Aug. 14, 2023, 7:07 a.m. UTC | #1
On Fri, 2023-08-11 at 18:20 +0800, Zheng Zengkai wrote:
> PCI core API pci_dev_id() can be used to get the BDF number for a pci
> device. We don't need to compose it mannually. Use pci_dev_id() to
> simplify the code a little bit.
> 
> Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>

Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
Michael Ellerman Aug. 23, 2023, 11:55 a.m. UTC | #2
On Fri, 11 Aug 2023 18:20:39 +0800, Zheng Zengkai wrote:
> PCI core API pci_dev_id() can be used to get the BDF number for a pci
> device. We don't need to compose it mannually. Use pci_dev_id() to
> simplify the code a little bit.
> 
> 

Applied to powerpc/next.

[1/1] ocxl: Use pci_dev_id() to simplify the code
      https://git.kernel.org/powerpc/c/075a88d5eb2806712c64bed98c30b6890ec30311

cheers
diff mbox series

Patch

diff --git a/arch/powerpc/platforms/powernv/ocxl.c b/arch/powerpc/platforms/powernv/ocxl.c
index 629067781cec..64a9c7125c29 100644
--- a/arch/powerpc/platforms/powernv/ocxl.c
+++ b/arch/powerpc/platforms/powernv/ocxl.c
@@ -449,7 +449,7 @@  int pnv_ocxl_spa_setup(struct pci_dev *dev, void *spa_mem, int PE_mask,
 	if (!data)
 		return -ENOMEM;
 
-	bdfn = (dev->bus->number << 8) | dev->devfn;
+	bdfn = pci_dev_id(dev);
 	rc = opal_npu_spa_setup(phb->opal_id, bdfn, virt_to_phys(spa_mem),
 				PE_mask);
 	if (rc) {