| Message ID | 20220716070758.539434-1-windhl@126.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | powerpc/powermac/low_i2c: Fix refcount leak bug in kw_i2c_probe() | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 10 jobs. |
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 10 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 23 jobs. |
On Sat, 16 Jul 2022 15:07:58 +0800, Liang He wrote: > We should call of_node_put() for the reference 'parent' returned by > of_get_parent() which has increased the refcount. > > Applied to powerpc/next. [1/1] powerpc/powermac/low_i2c: Fix refcount leak bug in kw_i2c_probe() https://git.kernel.org/powerpc/c/b3d6637bcc5d17caec56a76f6e430dcf444ef80e cheers
diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c index c1c430c66dc9..40f3aa432fba 100644 --- a/arch/powerpc/platforms/powermac/low_i2c.c +++ b/arch/powerpc/platforms/powermac/low_i2c.c @@ -627,6 +627,7 @@ static void __init kw_i2c_probe(void) if (parent == NULL) continue; chans = parent->name[0] == 'u' ? 2 : 1; + of_node_put(parent); for (i = 0; i < chans; i++) kw_i2c_add(host, np, np, i); } else {
We should call of_node_put() for the reference 'parent' returned by of_get_parent() which has increased the refcount. Fixes: 730745a5c450 ("[PATCH] 1/5 powerpc: Rework PowerMac i2c part 1") Signed-off-by: Liang He <windhl@126.com> --- arch/powerpc/platforms/powermac/low_i2c.c | 1 + 1 file changed, 1 insertion(+)