diff mbox series

powerpc: sysdev: Fix refcount leak bug in mpic_msgr

Message ID 20220617151252.4051291-1-windhl@126.com (mailing list archive)
State Superseded
Headers show
Series powerpc: sysdev: Fix refcount leak bug in mpic_msgr | expand

Checks

Context Check Description
snowpatch_ozlabs/github-powerpc_selftests success Successfully ran 10 jobs.
snowpatch_ozlabs/github-powerpc_ppctests success Successfully ran 10 jobs.
snowpatch_ozlabs/github-powerpc_clang success Successfully ran 7 jobs.
snowpatch_ozlabs/github-powerpc_sparse success Successfully ran 4 jobs.
snowpatch_ozlabs/github-powerpc_kernel_qemu success Successfully ran 23 jobs.

Commit Message

Liang He June 17, 2022, 3:12 p.m. UTC 
In mpic_msgr_number_of_blocks() and mpic_msgr_block_number(),
of_find_node_by_name() will return a node pointer with refcount
incremented. We should use of_node_put() when it is not used
anymore.

Signed-off-by: Liang He <windhl@126.com>
---
 arch/powerpc/sysdev/mpic_msgr.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/arch/powerpc/sysdev/mpic_msgr.c b/arch/powerpc/sysdev/mpic_msgr.c
index 698fefaaa6dd..c2a235d9eb09 100644
--- a/arch/powerpc/sysdev/mpic_msgr.c
+++ b/arch/powerpc/sysdev/mpic_msgr.c
@@ -122,6 +122,7 @@  static unsigned int mpic_msgr_number_of_blocks(void)
 			count += 1;
 		}
 	}
+	of_node_put(aliases);
 
 	return count;
 }
@@ -150,6 +151,7 @@  static int mpic_msgr_block_number(struct device_node *node)
 		if (node == of_find_node_by_path(prop->value))
 			break;
 	}
+	of_node_put(aliases);
 
 	return index == number_of_blocks ? -1 : index;
 }