diff mbox series

powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in hlwd_pic_probe

Message ID 20211103014833.163615-1-heying24@huawei.com (mailing list archive)
State Superseded
Headers show
Series powerpc/embedded6xx/hlwd-pic: Add missing of_node_put in hlwd_pic_probe | expand

Commit Message

He Ying Nov. 3, 2021, 1:48 a.m. UTC
Early exits from for_each_compatible_node() should decrease the
node reference count.

Signed-off-by: He Ying <heying24@huawei.com>
---
 arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 1 +
 1 file changed, 1 insertion(+)

Comments

He Ying Nov. 9, 2021, 2:07 a.m. UTC | #1
kindly ping...

在 2021/11/3 9:48, He Ying 写道:
> Early exits from for_each_compatible_node() should decrease the
> node reference count.
>
> Signed-off-by: He Ying <heying24@huawei.com>
> ---
>   arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> index 15396333a90b..a4b020e4b6af 100644
> --- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> +++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
> @@ -214,6 +214,7 @@ void hlwd_pic_probe(void)
>   			irq_set_chained_handler(cascade_virq,
>   						hlwd_pic_irq_cascade);
>   			hlwd_irq_host = host;
> +			of_node_put(np);
>   			break;
>   		}
>   	}
diff mbox series

Patch

diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
index 15396333a90b..a4b020e4b6af 100644
--- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
+++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
@@ -214,6 +214,7 @@  void hlwd_pic_probe(void)
 			irq_set_chained_handler(cascade_virq,
 						hlwd_pic_irq_cascade);
 			hlwd_irq_host = host;
+			of_node_put(np);
 			break;
 		}
 	}