| Message ID | 20210922084415.18269-1-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RESEND,1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration | expand |
| Related | show |
Le 22/09/2021 à 10:44, Krzysztof Kozlowski a écrit : > g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c, > so it should have a declaration to fix W=1 warning: > > arch/powerpc/platforms/powermac/feature.c:1533:6: > error: no previous prototype for ‘g5_phy_disable_cpu1’ [-Werror=missing-prototypes] While you are at it, can you clean it up completely, that is remove the declaration in arch/powerpc/platforms/powermac/smp.c ? > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > arch/powerpc/include/asm/pmac_feature.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/powerpc/include/asm/pmac_feature.h b/arch/powerpc/include/asm/pmac_feature.h > index e08e829261b6..7703e5bf1203 100644 > --- a/arch/powerpc/include/asm/pmac_feature.h > +++ b/arch/powerpc/include/asm/pmac_feature.h > @@ -143,6 +143,10 @@ > */ > struct device_node; > > +#ifdef CONFIG_PPC64 > +void g5_phy_disable_cpu1(void); > +#endif /* CONFIG_PPC64 */ > + > static inline long pmac_call_feature(int selector, struct device_node* node, > long param, long value) > { >
On 22/09/2021 15:52, Christophe Leroy wrote: > > > Le 22/09/2021 à 10:44, Krzysztof Kozlowski a écrit : >> g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c, >> so it should have a declaration to fix W=1 warning: >> >> arch/powerpc/platforms/powermac/feature.c:1533:6: >> error: no previous prototype for ‘g5_phy_disable_cpu1’ [-Werror=missing-prototypes] > > > While you are at it, can you clean it up completely, that is remove the > declaration in arch/powerpc/platforms/powermac/smp.c ? > Sure, I'll send a v2. Thanks for pointing this out. Best regards, Krzysztof
diff --git a/arch/powerpc/include/asm/pmac_feature.h b/arch/powerpc/include/asm/pmac_feature.h index e08e829261b6..7703e5bf1203 100644 --- a/arch/powerpc/include/asm/pmac_feature.h +++ b/arch/powerpc/include/asm/pmac_feature.h @@ -143,6 +143,10 @@ */ struct device_node; +#ifdef CONFIG_PPC64 +void g5_phy_disable_cpu1(void); +#endif /* CONFIG_PPC64 */ + static inline long pmac_call_feature(int selector, struct device_node* node, long param, long value) {
g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c, so it should have a declaration to fix W=1 warning: arch/powerpc/platforms/powermac/feature.c:1533:6: error: no previous prototype for ‘g5_phy_disable_cpu1’ [-Werror=missing-prototypes] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- arch/powerpc/include/asm/pmac_feature.h | 4 ++++ 1 file changed, 4 insertions(+)