| Message ID | 20210908071631.660-2-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/2] soc: fsl: guts: Make use of the helper function devm_platform_ioremap_resource() | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
On Wed, Sep 8, 2021 at 2:20 AM Cai Huoqing <caihuoqing@baidu.com> wrote: > > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> Applied for next. Thanks. > --- > drivers/soc/fsl/rcpm.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/soc/fsl/rcpm.c b/drivers/soc/fsl/rcpm.c > index 90d3f4060b0c..3d0cae30c769 100644 > --- a/drivers/soc/fsl/rcpm.c > +++ b/drivers/soc/fsl/rcpm.c > @@ -146,7 +146,6 @@ static const struct dev_pm_ops rcpm_pm_ops = { > static int rcpm_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - struct resource *r; > struct rcpm *rcpm; > int ret; > > @@ -154,11 +153,7 @@ static int rcpm_probe(struct platform_device *pdev) > if (!rcpm) > return -ENOMEM; > > - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!r) > - return -ENODEV; > - > - rcpm->ippdexpcr_base = devm_ioremap_resource(&pdev->dev, r); > + rcpm->ippdexpcr_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(rcpm->ippdexpcr_base)) { > ret = PTR_ERR(rcpm->ippdexpcr_base); > return ret; > -- > 2.25.1 >
diff --git a/drivers/soc/fsl/rcpm.c b/drivers/soc/fsl/rcpm.c index 90d3f4060b0c..3d0cae30c769 100644 --- a/drivers/soc/fsl/rcpm.c +++ b/drivers/soc/fsl/rcpm.c @@ -146,7 +146,6 @@ static const struct dev_pm_ops rcpm_pm_ops = { static int rcpm_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct resource *r; struct rcpm *rcpm; int ret; @@ -154,11 +153,7 @@ static int rcpm_probe(struct platform_device *pdev) if (!rcpm) return -ENOMEM; - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) - return -ENODEV; - - rcpm->ippdexpcr_base = devm_ioremap_resource(&pdev->dev, r); + rcpm->ippdexpcr_base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(rcpm->ippdexpcr_base)) { ret = PTR_ERR(rcpm->ippdexpcr_base); return ret;
Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/soc/fsl/rcpm.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)