| Message ID | 20210728081320.20394-3-wangkefeng.wang@huawei.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | sections: Unify kernel sections range check and use | expand |
| Related | show |
On Wed, 28 Jul 2021 16:13:15 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote: > The is_kernel_inittext/is_kernel_text/is_kernel function should not > include the end address(the labels _einittext, _etext and _end) when > check the address range, the issue exists since Linux v2.6.12. > > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > Cc: Petr Mladek <pmladek@suse.com> > Acked-by: Sergey Senozhatsky <senozhatsky@chromium.org> > Reviewed-by: Petr Mladek <pmladek@suse.com> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> -- Steve > --- > include/linux/kallsyms.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h > index 2a241e3f063f..b016c62f30a6 100644 > --- a/include/linux/kallsyms.h > +++ b/include/linux/kallsyms.h > @@ -27,21 +27,21 @@ struct module; > static inline int is_kernel_inittext(unsigned long addr) > { > if (addr >= (unsigned long)_sinittext > - && addr <= (unsigned long)_einittext) > + && addr < (unsigned long)_einittext) > return 1; > return 0; > } > > static inline int is_kernel_text(unsigned long addr) > { > - if ((addr >= (unsigned long)_stext && addr <= (unsigned long)_etext)) > + if ((addr >= (unsigned long)_stext && addr < (unsigned long)_etext)) > return 1; > return in_gate_area_no_mm(addr); > } > > static inline int is_kernel(unsigned long addr) > { > - if (addr >= (unsigned long)_stext && addr <= (unsigned long)_end) > + if (addr >= (unsigned long)_stext && addr < (unsigned long)_end) > return 1; > return in_gate_area_no_mm(addr); > }
On 2021/7/28 22:46, Steven Rostedt wrote: > On Wed, 28 Jul 2021 16:13:15 +0800 > Kefeng Wang <wangkefeng.wang@huawei.com> wrote: > >> The is_kernel_inittext/is_kernel_text/is_kernel function should not >> include the end address(the labels _einittext, _etext and _end) when >> check the address range, the issue exists since Linux v2.6.12. >> >> Cc: Arnd Bergmann <arnd@arndb.de> >> Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> >> Cc: Petr Mladek <pmladek@suse.com> >> Acked-by: Sergey Senozhatsky <senozhatsky@chromium.org> >> Reviewed-by: Petr Mladek <pmladek@suse.com> >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Thanks. > > -- Steve >
diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h index 2a241e3f063f..b016c62f30a6 100644 --- a/include/linux/kallsyms.h +++ b/include/linux/kallsyms.h @@ -27,21 +27,21 @@ struct module; static inline int is_kernel_inittext(unsigned long addr) { if (addr >= (unsigned long)_sinittext - && addr <= (unsigned long)_einittext) + && addr < (unsigned long)_einittext) return 1; return 0; } static inline int is_kernel_text(unsigned long addr) { - if ((addr >= (unsigned long)_stext && addr <= (unsigned long)_etext)) + if ((addr >= (unsigned long)_stext && addr < (unsigned long)_etext)) return 1; return in_gate_area_no_mm(addr); } static inline int is_kernel(unsigned long addr) { - if (addr >= (unsigned long)_stext && addr <= (unsigned long)_end) + if (addr >= (unsigned long)_stext && addr < (unsigned long)_end) return 1; return in_gate_area_no_mm(addr); }