| Message ID | 20210518204044.2390064-1-ndesaulniers@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] powerpc/powernv/pci: fix header guard | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (3a81c0495fdb91fd9a9b4f617098c283131eeae1) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On 5/18/2021 1:40 PM, Nick Desaulniers wrote: > While looking at -Wundef warnings, the #if CONFIG_EEH stood out as a > possible candidate to convert to #ifdef CONFIG_EEH. > > It seems that based on Kconfig dependencies it's not possible to build > this file without CONFIG_EEH enabled, but based on upstream discussion, > it's not clear yet that CONFIG_EEH should be enabled by default. > > For now, simply fix the -Wundef warning. > > Suggested-by: Nathan Chancellor <nathan@kernel.org> > Suggested-by: Joe Perches <joe@perches.com> > Link: https://github.com/ClangBuiltLinux/linux/issues/570 > Link: https://lore.kernel.org/lkml/67f6cd269684c9aa8463ff4812c3b4605e6739c3.camel@perches.com/ > Link: https://lore.kernel.org/lkml/CAOSf1CGoN5R0LUrU=Y=UWho1Z_9SLgCX8s3SbFJXwJXc5BYz4A@mail.gmail.com/ > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Makes sense, thanks for the patch! Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > arch/powerpc/platforms/powernv/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/pci.c b/arch/powerpc/platforms/powernv/pci.c > index b18468dc31ff..6bb3c52633fb 100644 > --- a/arch/powerpc/platforms/powernv/pci.c > +++ b/arch/powerpc/platforms/powernv/pci.c > @@ -711,7 +711,7 @@ int pnv_pci_cfg_write(struct pci_dn *pdn, > return PCIBIOS_SUCCESSFUL; > } > > -#if CONFIG_EEH > +#ifdef CONFIG_EEH > static bool pnv_pci_cfg_check(struct pci_dn *pdn) > { > struct eeh_dev *edev = NULL; >
On Tue, 18 May 2021 13:40:41 -0700, Nick Desaulniers wrote: > While looking at -Wundef warnings, the #if CONFIG_EEH stood out as a > possible candidate to convert to #ifdef CONFIG_EEH. > > It seems that based on Kconfig dependencies it's not possible to build > this file without CONFIG_EEH enabled, but based on upstream discussion, > it's not clear yet that CONFIG_EEH should be enabled by default. > > [...] Applied to powerpc/next. [1/1] powerpc/powernv/pci: fix header guard https://git.kernel.org/powerpc/c/73e6e4e01134c9ee97433ad1f470c71b0748b08f cheers
diff --git a/arch/powerpc/platforms/powernv/pci.c b/arch/powerpc/platforms/powernv/pci.c index b18468dc31ff..6bb3c52633fb 100644 --- a/arch/powerpc/platforms/powernv/pci.c +++ b/arch/powerpc/platforms/powernv/pci.c @@ -711,7 +711,7 @@ int pnv_pci_cfg_write(struct pci_dn *pdn, return PCIBIOS_SUCCESSFUL; } -#if CONFIG_EEH +#ifdef CONFIG_EEH static bool pnv_pci_cfg_check(struct pci_dn *pdn) { struct eeh_dev *edev = NULL;
While looking at -Wundef warnings, the #if CONFIG_EEH stood out as a possible candidate to convert to #ifdef CONFIG_EEH. It seems that based on Kconfig dependencies it's not possible to build this file without CONFIG_EEH enabled, but based on upstream discussion, it's not clear yet that CONFIG_EEH should be enabled by default. For now, simply fix the -Wundef warning. Suggested-by: Nathan Chancellor <nathan@kernel.org> Suggested-by: Joe Perches <joe@perches.com> Link: https://github.com/ClangBuiltLinux/linux/issues/570 Link: https://lore.kernel.org/lkml/67f6cd269684c9aa8463ff4812c3b4605e6739c3.camel@perches.com/ Link: https://lore.kernel.org/lkml/CAOSf1CGoN5R0LUrU=Y=UWho1Z_9SLgCX8s3SbFJXwJXc5BYz4A@mail.gmail.com/ Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- arch/powerpc/platforms/powernv/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)