| Message ID | 20210407125712.4138033-1-yukuai3@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | macintosh/windfarm: Make symbol 'pm121_sys_state' static | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (571b0d1ccf5cd3dc1b9866a908769ee23f7d127e) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded and removed 1 sparse warnings |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On Wed, 7 Apr 2021 20:57:12 +0800, Yu Kuai wrote: > The sparse tool complains as follows: > > drivers/macintosh/windfarm_pm121.c:436:24: warning: > symbol 'pm121_sys_state' was not declared. Should it be static? > > This symbol is not used outside of windfarm_pm121.c, so this > commit marks it static. Applied to powerpc/next. [1/1] macintosh/windfarm: Make symbol 'pm121_sys_state' static https://git.kernel.org/powerpc/c/13ddd0e3acf988a98b46800178ae691640b0cd00 cheers
diff --git a/drivers/macintosh/windfarm_pm121.c b/drivers/macintosh/windfarm_pm121.c index ab467b9c31be..ba1ec6fc11d2 100644 --- a/drivers/macintosh/windfarm_pm121.c +++ b/drivers/macintosh/windfarm_pm121.c @@ -433,7 +433,7 @@ struct pm121_sys_state { struct wf_pid_state pid; }; -struct pm121_sys_state *pm121_sys_state[N_LOOPS] = {}; +static struct pm121_sys_state *pm121_sys_state[N_LOOPS] = {}; /* * ****** CPU Fans Control Loop ******
The sparse tool complains as follows: drivers/macintosh/windfarm_pm121.c:436:24: warning: symbol 'pm121_sys_state' was not declared. Should it be static? This symbol is not used outside of windfarm_pm121.c, so this commit marks it static. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yu Kuai <yukuai3@huawei.com> --- drivers/macintosh/windfarm_pm121.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)