| Message ID | 20210403020423.85278-1-syl.loop@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/dts: fix not include DTC_FLAGS | expand |
| Related | show |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (87d76f542a24ecfa797e9bd3bb56c0f19aabff57) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 6 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
Youlin Song <syl.loop@gmail.com> writes: > I wanted to build the fsl dts in my machine and found that > the dtb have not extra space,so uboot will cause about > FDT_ERR_NOSPACE issue. > > Signed-off-by: Youlin Song <syl.loop@gmail.com> > --- > arch/powerpc/boot/dts/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/boot/dts/Makefile b/arch/powerpc/boot/dts/Makefile > index fb335d05aae8..c21165c0cd76 100644 > --- a/arch/powerpc/boot/dts/Makefile > +++ b/arch/powerpc/boot/dts/Makefile > @@ -2,5 +2,6 @@ > > subdir-y += fsl > > +DTC_FLAGS ?= -p 1024 > dtstree := $(srctree)/$(src) > dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts)) I guess that was missed in 1acf1cf8638a ("powerpc: build .dtb files in dts directory"). Which I think means the assignment to DTC_FLAGS in arch/powerpc/boot/Makefile is not needed anymore. Can you send a v2 removing that assignment and explaining that's what happened? cheers
On Wed, Apr 7, 2021 at 6:27 AM Michael Ellerman <mpe@ellerman.id.au> wrote: > > Youlin Song <syl.loop@gmail.com> writes: > > I wanted to build the fsl dts in my machine and found that > > the dtb have not extra space,so uboot will cause about > > FDT_ERR_NOSPACE issue. How do we not have issues with arm and arm64 boards which don't have padding? Or what took so long to notice on powerpc? > > > > Signed-off-by: Youlin Song <syl.loop@gmail.com> > > --- > > arch/powerpc/boot/dts/Makefile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/powerpc/boot/dts/Makefile b/arch/powerpc/boot/dts/Makefile > > index fb335d05aae8..c21165c0cd76 100644 > > --- a/arch/powerpc/boot/dts/Makefile > > +++ b/arch/powerpc/boot/dts/Makefile > > @@ -2,5 +2,6 @@ > > > > subdir-y += fsl > > > > +DTC_FLAGS ?= -p 1024 > > dtstree := $(srctree)/$(src) > > dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts)) > > I guess that was missed in 1acf1cf8638a ("powerpc: build .dtb files in dts directory"). > > Which I think means the assignment to DTC_FLAGS in > arch/powerpc/boot/Makefile is not needed anymore. > > Can you send a v2 removing that assignment and explaining that's what > happened? I've wanted to make this common, but I guess that's a separate change. Rob
In my test, DTC_FLAGS in arch/powerpc/boot/Makefile is not to work,I will send V2 to removing it. Michael Ellerman <mpe@ellerman.id.au> 于2021年4月7日周三 下午7:27写道： > Youlin Song <syl.loop@gmail.com> writes: > > I wanted to build the fsl dts in my machine and found that > > the dtb have not extra space,so uboot will cause about > > FDT_ERR_NOSPACE issue. > > > > Signed-off-by: Youlin Song <syl.loop@gmail.com> > > --- > > arch/powerpc/boot/dts/Makefile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/powerpc/boot/dts/Makefile > b/arch/powerpc/boot/dts/Makefile > > index fb335d05aae8..c21165c0cd76 100644 > > --- a/arch/powerpc/boot/dts/Makefile > > +++ b/arch/powerpc/boot/dts/Makefile > > @@ -2,5 +2,6 @@ > > > > subdir-y += fsl > > > > +DTC_FLAGS ?= -p 1024 > > dtstree := $(srctree)/$(src) > > dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, > $(wildcard $(dtstree)/*.dts)) > > I guess that was missed in 1acf1cf8638a ("powerpc: build .dtb files in dts > directory"). > > Which I think means the assignment to DTC_FLAGS in > arch/powerpc/boot/Makefile is not needed anymore. > > Can you send a v2 removing that assignment and explaining that's what > happened? > > cheers >
diff --git a/arch/powerpc/boot/dts/Makefile b/arch/powerpc/boot/dts/Makefile index fb335d05aae8..c21165c0cd76 100644 --- a/arch/powerpc/boot/dts/Makefile +++ b/arch/powerpc/boot/dts/Makefile @@ -2,5 +2,6 @@ subdir-y += fsl +DTC_FLAGS ?= -p 1024 dtstree := $(srctree)/$(src) dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
I wanted to build the fsl dts in my machine and found that the dtb have not extra space,so uboot will cause about FDT_ERR_NOSPACE issue. Signed-off-by: Youlin Song <syl.loop@gmail.com> --- arch/powerpc/boot/dts/Makefile | 1 + 1 file changed, 1 insertion(+)