| Message ID | 20210225134652.2127648-3-npiggin@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | KVM: PPC: Book3S: C-ify the P9 entry/exit code | expand |
Hi Nick, > This config option causes the warning in init_default_hcalls to fire > because the TCE handlers are in the default hcall list but not > implemented. I checked that the TCE handlers are indeed not defined unless CONFIG_SPAPR_TCE_IOMMU=y, and so I can see how you would hit the warning. This seems like the right solution to me. Reviewed-by: Daniel Axtens <dja@axtens.net> Kind regards, Daniel > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > --- > arch/powerpc/kvm/book3s_hv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index 13bad6bf4c95..895090636295 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -5369,8 +5369,10 @@ static unsigned int default_hcall_list[] = { > H_READ, > H_PROTECT, > H_BULK_REMOVE, > +#ifdef CONFIG_SPAPR_TCE_IOMMU > H_GET_TCE, > H_PUT_TCE, > +#endif > H_SET_DABR, > H_SET_XDABR, > H_CEDE, > -- > 2.23.0
diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c index 13bad6bf4c95..895090636295 100644 --- a/arch/powerpc/kvm/book3s_hv.c +++ b/arch/powerpc/kvm/book3s_hv.c @@ -5369,8 +5369,10 @@ static unsigned int default_hcall_list[] = { H_READ, H_PROTECT, H_BULK_REMOVE, +#ifdef CONFIG_SPAPR_TCE_IOMMU H_GET_TCE, H_PUT_TCE, +#endif H_SET_DABR, H_SET_XDABR, H_CEDE,
This config option causes the warning in init_default_hcalls to fire because the TCE handlers are in the default hcall list but not implemented. Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- arch/powerpc/kvm/book3s_hv.c | 2 ++ 1 file changed, 2 insertions(+)