| Message ID | 20210105022229.54601-1-mpe@ellerman.id.au (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | net: ethernet: fs_enet: Add missing MODULE_LICENSE | expand |
On Tue, Jan 05, 2021 at 01:22:29PM +1100, Michael Ellerman wrote: > Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() > into error") the ppc32_allmodconfig build fails with: > > ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-fec.o > ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-bitbang.o > > Add the missing MODULE_LICENSEs to fix the build. Both files include a > copyright header indicating they are GPL v2. > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > --- > drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 1 + > drivers/net/ethernet/freescale/fs_enet/mii-fec.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c > index c8e5d889bd81..76ac1a9eab58 100644 > --- a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c > +++ b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c > @@ -223,3 +223,4 @@ static struct platform_driver fs_enet_bb_mdio_driver = { > }; > > module_platform_driver(fs_enet_bb_mdio_driver); > +MODULE_LICENSE("GPL v2"); > diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c > index 8b51ee142fa3..407c330b432f 100644 > --- a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c > +++ b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c > @@ -224,3 +224,4 @@ static struct platform_driver fs_enet_fec_mdio_driver = { > }; > > module_platform_driver(fs_enet_fec_mdio_driver); > +MODULE_LICENSE("GPL v2"); Hi Michael The use of "GPL v2" has been deprecated. Please use just "GPL". There is a discussion about this here: https://lore.kernel.org/patchwork/patch/1036331/ https://www.kernel.org/doc/html/latest/process/license-rules.html#id1 Andrew
Andrew Lunn <andrew@lunn.ch> writes: > On Tue, Jan 05, 2021 at 01:22:29PM +1100, Michael Ellerman wrote: >> Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() >> into error") the ppc32_allmodconfig build fails with: >> >> ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-fec.o >> ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-bitbang.o >> >> Add the missing MODULE_LICENSEs to fix the build. Both files include a >> copyright header indicating they are GPL v2. >> >> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> >> --- >> drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 1 + >> drivers/net/ethernet/freescale/fs_enet/mii-fec.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c >> index c8e5d889bd81..76ac1a9eab58 100644 >> --- a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c >> +++ b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c >> @@ -223,3 +223,4 @@ static struct platform_driver fs_enet_bb_mdio_driver = { >> }; >> >> module_platform_driver(fs_enet_bb_mdio_driver); >> +MODULE_LICENSE("GPL v2"); >> diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c >> index 8b51ee142fa3..407c330b432f 100644 >> --- a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c >> +++ b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c >> @@ -224,3 +224,4 @@ static struct platform_driver fs_enet_fec_mdio_driver = { >> }; >> >> module_platform_driver(fs_enet_fec_mdio_driver); >> +MODULE_LICENSE("GPL v2"); > > Hi Michael > > The use of "GPL v2" has been deprecated. Please use just "GPL". There > is a discussion about this here: > > https://lore.kernel.org/patchwork/patch/1036331/ > > https://www.kernel.org/doc/html/latest/process/license-rules.html#id1 Ah sorry, I just grepped for "GPL v2" and saw lots of examples so copied that. Will post a new version using "GPL". cheers
diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c index c8e5d889bd81..76ac1a9eab58 100644 --- a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c +++ b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c @@ -223,3 +223,4 @@ static struct platform_driver fs_enet_bb_mdio_driver = { }; module_platform_driver(fs_enet_bb_mdio_driver); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c index 8b51ee142fa3..407c330b432f 100644 --- a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c +++ b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c @@ -224,3 +224,4 @@ static struct platform_driver fs_enet_fec_mdio_driver = { }; module_platform_driver(fs_enet_fec_mdio_driver); +MODULE_LICENSE("GPL v2");
Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into error") the ppc32_allmodconfig build fails with: ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-fec.o ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-bitbang.o Add the missing MODULE_LICENSEs to fix the build. Both files include a copyright header indicating they are GPL v2. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 1 + drivers/net/ethernet/freescale/fs_enet/mii-fec.c | 1 + 2 files changed, 2 insertions(+)