| Message ID | 20200924051343.16052.9571.stgit@localhost.localdomain (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rpadlpar_io:Add MODULE_DESCRIPTION entries to kernel modules | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (ace1986562a0814f179ecd2f1e648215ebc6625a) |
| snowpatch_ozlabs/build-ppc64le | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-ppc64be | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-ppc64e | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-pmac32 | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 4 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On Thu, Sep 24, 2020 at 3:15 PM Mamatha Inamdar <mamatha4@linux.vnet.ibm.com> wrote: > > This patch adds a brief MODULE_DESCRIPTION to rpadlpar_io kernel modules > (descriptions taken from Kconfig file) > > Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com> > --- > drivers/pci/hotplug/rpadlpar_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c > index f979b70..bac65ed 100644 > --- a/drivers/pci/hotplug/rpadlpar_core.c > +++ b/drivers/pci/hotplug/rpadlpar_core.c > @@ -478,3 +478,4 @@ static void __exit rpadlpar_io_exit(void) > module_init(rpadlpar_io_init); > module_exit(rpadlpar_io_exit); > MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("RPA Dynamic Logical Partitioning driver for I/O slots"); RPA as a spec was superseded by PAPR in the early 2000s. Can we rename this already? The only potential problem I can see is scripts doing: modprobe rpadlpar_io or similar However, we should be able to fix that with a module alias. Oliver
On Thu, Sep 24, 2020 at 04:41:39PM +1000, Oliver O'Halloran wrote: > On Thu, Sep 24, 2020 at 3:15 PM Mamatha Inamdar > <mamatha4@linux.vnet.ibm.com> wrote: > > > > This patch adds a brief MODULE_DESCRIPTION to rpadlpar_io kernel modules > > (descriptions taken from Kconfig file) > > > > Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com> > > --- > > drivers/pci/hotplug/rpadlpar_core.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c > > index f979b70..bac65ed 100644 > > --- a/drivers/pci/hotplug/rpadlpar_core.c > > +++ b/drivers/pci/hotplug/rpadlpar_core.c > > @@ -478,3 +478,4 @@ static void __exit rpadlpar_io_exit(void) > > module_init(rpadlpar_io_init); > > module_exit(rpadlpar_io_exit); > > MODULE_LICENSE("GPL"); > > +MODULE_DESCRIPTION("RPA Dynamic Logical Partitioning driver for I/O slots"); > > RPA as a spec was superseded by PAPR in the early 2000s. Can we rename > this already? > > The only potential problem I can see is scripts doing: modprobe > rpadlpar_io or similar > > However, we should be able to fix that with a module alias. Is MODULE_DESCRIPTION() connected with how modprobe works? If this patch just improves documentation, without breaking users of modprobe, I'm fine with it, even if it would be nice to rename to PAPR or something in the future. But, please use "git log --oneline drivers/pci/hotplug/rpadlpar*" and match the style, and also look through the rest of drivers/pci/ to see if we should do the same thing to any other modules. Bjorn
On Sat, Sep 26, 2020 at 5:43 AM Bjorn Helgaas <helgaas@kernel.org> wrote: > > On Thu, Sep 24, 2020 at 04:41:39PM +1000, Oliver O'Halloran wrote: > > On Thu, Sep 24, 2020 at 3:15 PM Mamatha Inamdar > > <mamatha4@linux.vnet.ibm.com> wrote: > > > > > > This patch adds a brief MODULE_DESCRIPTION to rpadlpar_io kernel modules > > > (descriptions taken from Kconfig file) > > > > > > Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com> > > > --- > > > drivers/pci/hotplug/rpadlpar_core.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c > > > index f979b70..bac65ed 100644 > > > --- a/drivers/pci/hotplug/rpadlpar_core.c > > > +++ b/drivers/pci/hotplug/rpadlpar_core.c > > > @@ -478,3 +478,4 @@ static void __exit rpadlpar_io_exit(void) > > > module_init(rpadlpar_io_init); > > > module_exit(rpadlpar_io_exit); > > > MODULE_LICENSE("GPL"); > > > +MODULE_DESCRIPTION("RPA Dynamic Logical Partitioning driver for I/O slots"); > > > > RPA as a spec was superseded by PAPR in the early 2000s. Can we rename > > this already? > > > > The only potential problem I can see is scripts doing: modprobe > > rpadlpar_io or similar > > > > However, we should be able to fix that with a module alias. > > Is MODULE_DESCRIPTION() connected with how modprobe works? I don't think so. The description is just there as an FYI. > If this patch just improves documentation, without breaking users of > modprobe, I'm fine with it, even if it would be nice to rename to PAPR > or something in the future. Right, the change in this patch is just a documentation fix and shouldn't cause any problems. I was suggesting renaming the module itself since the term "RPA" is only used in this hotplug driver and some of the corresponding PHB add / remove handling in arch/powerpc/platforms/pseries/. We can make that change in a follow up though. > But, please use "git log --oneline drivers/pci/hotplug/rpadlpar*" and > match the style, and also look through the rest of drivers/pci/ to see > if we should do the same thing to any other modules. > > Bjorn
On 9/23/20 11:41 PM, Oliver O'Halloran wrote: > On Thu, Sep 24, 2020 at 3:15 PM Mamatha Inamdar > <mamatha4@linux.vnet.ibm.com> wrote: >> >> This patch adds a brief MODULE_DESCRIPTION to rpadlpar_io kernel modules >> (descriptions taken from Kconfig file) >> >> Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com> >> --- >> drivers/pci/hotplug/rpadlpar_core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c >> index f979b70..bac65ed 100644 >> --- a/drivers/pci/hotplug/rpadlpar_core.c >> +++ b/drivers/pci/hotplug/rpadlpar_core.c >> @@ -478,3 +478,4 @@ static void __exit rpadlpar_io_exit(void) >> module_init(rpadlpar_io_init); >> module_exit(rpadlpar_io_exit); >> MODULE_LICENSE("GPL"); >> +MODULE_DESCRIPTION("RPA Dynamic Logical Partitioning driver for I/O slots"); > > RPA as a spec was superseded by PAPR in the early 2000s. Can we rename > this already? I seem to recall Michael and I discussed the naming briefly when I added the maintainer entries for the drivers and that the PAPR acronym is almost as meaningless to most as the original RPA. While, IBM no longer uses the term pseries for Power hardware marketing it is the defacto platform identifier in the Linux kernel tree for what we would call PAPR compliant. All in all I have no problem with renaming, but maybe we should consider pseries_dlpar or even simpler ibmdlpar. > > The only potential problem I can see is scripts doing: modprobe > rpadlpar_io or similar > > However, we should be able to fix that with a module alias. Agreed. -Tyrel > > Oliver >
On Tue, Sep 29, 2020 at 6:50 AM Tyrel Datwyler <tyreld@linux.ibm.com> wrote: > > On 9/23/20 11:41 PM, Oliver O'Halloran wrote: > > On Thu, Sep 24, 2020 at 3:15 PM Mamatha Inamdar > > <mamatha4@linux.vnet.ibm.com> wrote: > >> > >> This patch adds a brief MODULE_DESCRIPTION to rpadlpar_io kernel modules > >> (descriptions taken from Kconfig file) > >> > >> Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com> > >> --- > >> drivers/pci/hotplug/rpadlpar_core.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c > >> index f979b70..bac65ed 100644 > >> --- a/drivers/pci/hotplug/rpadlpar_core.c > >> +++ b/drivers/pci/hotplug/rpadlpar_core.c > >> @@ -478,3 +478,4 @@ static void __exit rpadlpar_io_exit(void) > >> module_init(rpadlpar_io_init); > >> module_exit(rpadlpar_io_exit); > >> MODULE_LICENSE("GPL"); > >> +MODULE_DESCRIPTION("RPA Dynamic Logical Partitioning driver for I/O slots"); > > > > RPA as a spec was superseded by PAPR in the early 2000s. Can we rename > > this already? > > I seem to recall Michael and I discussed the naming briefly when I added the > maintainer entries for the drivers and that the PAPR acronym is almost as > meaningless to most as the original RPA. While, IBM no longer uses the term > pseries for Power hardware marketing it is the defacto platform identifier in > the Linux kernel tree for what we would call PAPR compliant. All in all I have > no problem with renaming, but maybe we should consider pseries_dlpar or even > simpler ibmdlpar. I'm not too bothered by what we call it so long as it's consistent with *something* else in the tree. Using pseries rather than ibm as a prefix would probably be better since the legacy ibmphp driver is in the same directory.
On Thu, 24 Sep 2020 10:44:16 +0530, Mamatha Inamdar wrote: > This patch adds a brief MODULE_DESCRIPTION to rpadlpar_io kernel modules > (descriptions taken from Kconfig file) > > Applied to powerpc/next. [1/1] rpadlpar_io:Add MODULE_DESCRIPTION entries to kernel modules https://git.kernel.org/powerpc/c/be7be1c6c6f8bd348f0d83abe7a8f0e21bdaeac8 cheers
diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c index f979b70..bac65ed 100644 --- a/drivers/pci/hotplug/rpadlpar_core.c +++ b/drivers/pci/hotplug/rpadlpar_core.c @@ -478,3 +478,4 @@ static void __exit rpadlpar_io_exit(void) module_init(rpadlpar_io_init); module_exit(rpadlpar_io_exit); MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("RPA Dynamic Logical Partitioning driver for I/O slots");
This patch adds a brief MODULE_DESCRIPTION to rpadlpar_io kernel modules (descriptions taken from Kconfig file) Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com> --- drivers/pci/hotplug/rpadlpar_core.c | 1 + 1 file changed, 1 insertion(+)