| Message ID | 20200824080437.229826-1-yebin10@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (d4ecce4dcc8f8820286cf4e0859850c555e89854) |
| snowpatch_ozlabs/build-ppc64le | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-ppc64be | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-ppc64e | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-pmac32 | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/checkpatch | warning | total: 0 errors, 1 warnings, 0 checks, 15 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote: > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: > > Signed-off-by: Ye Bin <yebin10@huawei.com> > > I can't take patches without any changelog text, sorry. Still taking patches for fsl_udc_core.c ? I figured this driver was obsolete and should be moved to one of the Chipidea drivers. Jocke
Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes: > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote: >> >> On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: >> > Signed-off-by: Ye Bin <yebin10@huawei.com> >> >> I can't take patches without any changelog text, sorry. > > Still taking patches for fsl_udc_core.c ? > I figured this driver was obsolete and should be moved to one of the Chipidea drivers. Nobody sent any patches to switch over the users of this driver to chipidea. I would love to delete this driver :-)
On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote: > Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes: > > > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote: > > > > > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: > > > > Signed-off-by: Ye Bin <yebin10@huawei.com> > > > > > > I can't take patches without any changelog text, sorry. > > > > Still taking patches for fsl_udc_core.c ? > > I figured this driver was obsolete and should be moved to one of the Chipidea drivers. > > Nobody sent any patches to switch over the users of this driver to > chipidea. I would love to delete this driver :-) Me too, I got a few local patches here as the driver is quite buggy. Got to little USB knowledge to switch it over though :( Jocke
Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes: > On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote: >> Joakim Tjernlund <Joakim.Tjernlund@infinera.com> writes: >> >> > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote: >> > > >> > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: >> > > > Signed-off-by: Ye Bin <yebin10@huawei.com> >> > > >> > > I can't take patches without any changelog text, sorry. >> > >> > Still taking patches for fsl_udc_core.c ? >> > I figured this driver was obsolete and should be moved to one of the Chipidea drivers. >> >> Nobody sent any patches to switch over the users of this driver to >> chipidea. I would love to delete this driver :-) > > Me too, I got a few local patches here as the driver is quite buggy. > Got to little USB knowledge to switch it over though :( this wouldn't require USB knowledge. It only requires some minor DTS knowledge and HW for testing.
On Tue, 2020-08-25 at 11:53 +0300, Felipe Balbi wrote: Joakim Tjernlund <Joakim.Tjernlund@infinera.com<mailto:Joakim.Tjernlund@infinera.com>> writes: > On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote: >> Joakim Tjernlund <Joakim.Tjernlund@infinera.com<mailto:Joakim.Tjernlund@infinera.com>> writes: >> >> > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote: >> > > >> > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: >> > > > Signed-off-by: Ye Bin <yebin10@huawei.com<mailto:yebin10@huawei.com>> >> > > >> > > I can't take patches without any changelog text, sorry. >> > >> > Still taking patches for fsl_udc_core.c ? >> > I figured this driver was obsolete and should be moved to one of the Chipidea drivers. >> >> Nobody sent any patches to switch over the users of this driver to >> chipidea. I would love to delete this driver :-) > > Me too, I got a few local patches here as the driver is quite buggy. > Got to little USB knowledge to switch it over though :( this wouldn't require USB knowledge. It only requires some minor DTS knowledge and HW for testing. hmm, OK. If it is that simple I may take a crack at it(but then why hasn't NXP already done that ?) I would need some guidance as to what the involved files are? Jocke
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c index a6f7b2594c09..3e98740b8cfc 100644 --- a/drivers/usb/gadget/udc/fsl_udc_core.c +++ b/drivers/usb/gadget/udc/fsl_udc_core.c @@ -2439,11 +2439,12 @@ static int fsl_udc_probe(struct platform_device *pdev) /* DEN is bidirectional ep number, max_ep doubles the number */ udc_controller->max_ep = (dccparams & DCCPARAMS_DEN_MASK) * 2; - udc_controller->irq = platform_get_irq(pdev, 0); - if (udc_controller->irq <= 0) { - ret = udc_controller->irq ? : -ENODEV; + ret = platform_get_irq(pdev, 0); + if (ret <= 0) { + ret = ret ? : -ENODEV; goto err_iounmap; } + udc_controller->irq = ret; ret = request_irq(udc_controller->irq, fsl_udc_irq, IRQF_SHARED, driver_name, udc_controller);
Signed-off-by: Ye Bin <yebin10@huawei.com> --- drivers/usb/gadget/udc/fsl_udc_core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)