| Message ID | 20200807101956.67454-1-chenzefeng2@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | powerpc:entry_32: correct the path and function name in the comment | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (3cd2184115b85cc8242fec3d42529cd112962984) |
| snowpatch_ozlabs/build-ppc64le | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-ppc64be | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-ppc64e | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/build-pmac32 | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| snowpatch_ozlabs/needsstable | warning | Please consider tagging this patch for stable! |
Le 07/08/2020 à 12:19, chenzefeng a écrit : > Update the comment for file's directory and function name changed. > > Fixes: facd04a904ff ("powerpc: convert to copy_thread_tls") > Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.") > > Signed-off-by: chenzefeng <chenzefeng2@huawei.com> > --- > arch/powerpc/kernel/entry_32.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S > index 8420abd4ea1c..9937593d3a33 100644 > --- a/arch/powerpc/kernel/entry_32.S > +++ b/arch/powerpc/kernel/entry_32.S > @@ -696,8 +696,8 @@ handle_dabr_fault: > * to the "_switch" path. If you change this , you'll have to > * change the fork code also. > * > - * The code which creates the new task context is in 'copy_thread' > - * in arch/ppc/kernel/process.c > + * The code which creates the new task context is in 'copy_thread_tls' > + * in arch/powerpc/kernel/process.c Does it matters at all where the function is ? I'm sure people can find it themselves. Christophe > */ > _GLOBAL(_switch) > stwu r1,-INT_FRAME_SIZE(r1) >
Le 07/08/2020 à 12:19, chenzefeng a écrit : > Update the comment for file's directory and function name changed. The function name changed again with commit 714acdbd1c94 ("arch: rename copy_thread_tls() back to copy_thread()") Please update the patch to just drop the file name. Users are able to find where the function is by themselves. Thanks Christophe > > Fixes: facd04a904ff ("powerpc: convert to copy_thread_tls") > Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.") > > Signed-off-by: chenzefeng <chenzefeng2@huawei.com> > --- > arch/powerpc/kernel/entry_32.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S > index 8420abd4ea1c..9937593d3a33 100644 > --- a/arch/powerpc/kernel/entry_32.S > +++ b/arch/powerpc/kernel/entry_32.S > @@ -696,8 +696,8 @@ handle_dabr_fault: > * to the "_switch" path. If you change this , you'll have to > * change the fork code also. > * > - * The code which creates the new task context is in 'copy_thread' > - * in arch/ppc/kernel/process.c > + * The code which creates the new task context is in 'copy_thread_tls' > + * in arch/powerpc/kernel/process.c > */ > _GLOBAL(_switch) > stwu r1,-INT_FRAME_SIZE(r1)
diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S index 8420abd4ea1c..9937593d3a33 100644 --- a/arch/powerpc/kernel/entry_32.S +++ b/arch/powerpc/kernel/entry_32.S @@ -696,8 +696,8 @@ handle_dabr_fault: * to the "_switch" path. If you change this , you'll have to * change the fork code also. * - * The code which creates the new task context is in 'copy_thread' - * in arch/ppc/kernel/process.c + * The code which creates the new task context is in 'copy_thread_tls' + * in arch/powerpc/kernel/process.c */ _GLOBAL(_switch) stwu r1,-INT_FRAME_SIZE(r1)
Update the comment for file's directory and function name changed. Fixes: facd04a904ff ("powerpc: convert to copy_thread_tls") Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.") Signed-off-by: chenzefeng <chenzefeng2@huawei.com> --- arch/powerpc/kernel/entry_32.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)