| Message ID | 20200528230731.1235752-1-mikey@neuling.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 82a7cebdd95cffa55449d6c1d97cc9b743a66056 |
| Headers | show |
| Series | powerpc: Fix misleading small cores print | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (fff0b48b2415d08f9bc09e9e596b916b3817862b) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On Fri, May 29, 2020 at 09:07:31AM +1000, Michael Neuling wrote: > Currently when we boot on a big core system, we get this print: > [ 0.040500] Using small cores at SMT level > > This is misleading as we've actually detected big cores. > > This patch clears up the print to say we've detect big cores but are > using small cores for scheduling. Thanks for making the print more meaningful. > > Signed-off-by: Michael Neuling <mikey@neuling.org> FWIW, Acked-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com> > --- > arch/powerpc/kernel/smp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > index 6d2a3a3666..c820c95162 100644 > --- a/arch/powerpc/kernel/smp.c > +++ b/arch/powerpc/kernel/smp.c > @@ -1383,7 +1383,7 @@ void __init smp_cpus_done(unsigned int max_cpus) > > #ifdef CONFIG_SCHED_SMT > if (has_big_cores) { > - pr_info("Using small cores at SMT level\n"); > + pr_info("Big cores detected but using small core scheduling\n"); > power9_topology[0].mask = smallcore_smt_mask; > powerpc_topology[0].mask = smallcore_smt_mask; > } > -- > 2.26.2 >
On Fri, 29 May 2020 09:07:31 +1000, Michael Neuling wrote: > Currently when we boot on a big core system, we get this print: > [ 0.040500] Using small cores at SMT level > > This is misleading as we've actually detected big cores. > > This patch clears up the print to say we've detect big cores but are > using small cores for scheduling. Applied to powerpc/next. [1/1] powerpc: Fix misleading small cores print https://git.kernel.org/powerpc/c/82a7cebdd95cffa55449d6c1d97cc9b743a66056 cheers
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 6d2a3a3666..c820c95162 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc/kernel/smp.c @@ -1383,7 +1383,7 @@ void __init smp_cpus_done(unsigned int max_cpus) #ifdef CONFIG_SCHED_SMT if (has_big_cores) { - pr_info("Using small cores at SMT level\n"); + pr_info("Big cores detected but using small core scheduling\n"); power9_topology[0].mask = smallcore_smt_mask; powerpc_topology[0].mask = smallcore_smt_mask; }
Currently when we boot on a big core system, we get this print: [ 0.040500] Using small cores at SMT level This is misleading as we've actually detected big cores. This patch clears up the print to say we've detect big cores but are using small cores for scheduling. Signed-off-by: Michael Neuling <mikey@neuling.org> --- arch/powerpc/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)