| Message ID | 20200130063153.19915-2-oohall@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8cbb00a901037986f4066e2fc0d36a4882475662 |
| Headers | show |
| Series | [1/2] pseries/vio: Remove stray #ifdef CONFIG_PPC_PSERIES | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (23f1be8476528cfab2a015de5a4c5cecf69536d0) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 5 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On Thu, Jan 30, 2020 at 5:32 PM Oliver O'Halloran <oohall@gmail.com> wrote: > > The platform makefile (arch/powerpc/platforms/pseries/Makefile) is only doh s/platform/pseries/ > included by the platform makefile (arch/powerpc/platform/Makefile) when > CONFIG_PPC_PSERIES is selected, so checking for CONFIG_PPC_PSERIES in the > pseries makefile is pointless. > > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> > --- > arch/powerpc/platforms/pseries/Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/powerpc/platforms/pseries/Makefile b/arch/powerpc/platforms/pseries/Makefile > index a3c74a5..c8a2b0b 100644 > --- a/arch/powerpc/platforms/pseries/Makefile > +++ b/arch/powerpc/platforms/pseries/Makefile > @@ -29,6 +29,4 @@ obj-$(CONFIG_PPC_SPLPAR) += vphn.o > obj-$(CONFIG_PPC_SVM) += svm.o > obj-$(CONFIG_FA_DUMP) += rtas-fadump.o > > -ifdef CONFIG_PPC_PSERIES > obj-$(CONFIG_SUSPEND) += suspend.o > -endif > -- > 2.9.5 >
On 1/29/20 10:31 PM, Oliver O'Halloran wrote: > The platform makefile (arch/powerpc/platforms/pseries/Makefile) is only > included by the platform makefile (arch/powerpc/platform/Makefile) when > CONFIG_PPC_PSERIES is selected, so checking for CONFIG_PPC_PSERIES in the > pseries makefile is pointless. > > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
diff --git a/arch/powerpc/platforms/pseries/Makefile b/arch/powerpc/platforms/pseries/Makefile index a3c74a5..c8a2b0b 100644 --- a/arch/powerpc/platforms/pseries/Makefile +++ b/arch/powerpc/platforms/pseries/Makefile @@ -29,6 +29,4 @@ obj-$(CONFIG_PPC_SPLPAR) += vphn.o obj-$(CONFIG_PPC_SVM) += svm.o obj-$(CONFIG_FA_DUMP) += rtas-fadump.o -ifdef CONFIG_PPC_PSERIES obj-$(CONFIG_SUSPEND) += suspend.o -endif
The platform makefile (arch/powerpc/platforms/pseries/Makefile) is only included by the platform makefile (arch/powerpc/platform/Makefile) when CONFIG_PPC_PSERIES is selected, so checking for CONFIG_PPC_PSERIES in the pseries makefile is pointless. Signed-off-by: Oliver O'Halloran <oohall@gmail.com> --- arch/powerpc/platforms/pseries/Makefile | 2 -- 1 file changed, 2 deletions(-)