| Message ID | 20190724075433.9446-1-nishkadg.linux@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2] crypto: nx: nx-842-powernv: Add of_node_put() before return | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (f3365d1a959d5c6527efe3d38276acc9b58e3f3f) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
On Wed, Jul 24, 2019 at 01:24:33PM +0530, Nishka Dasgupta wrote: > Each iteration of for_each_compatible_node puts the previous node, but > in the case of a return from the middle of the loop, there is no put, > thus causing a memory leak. Add an of_node_put before the return. > Issue found with Coccinelle. > > Acked-by: Stewart Smith <stewart@linux.ibm.com> > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> > > --- > Changes in v2: > - Fixed commit message to match the loop in question. > > drivers/crypto/nx/nx-842-powernv.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks.
diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c index e78ff5c65ed6..c037a2403b82 100644 --- a/drivers/crypto/nx/nx-842-powernv.c +++ b/drivers/crypto/nx/nx-842-powernv.c @@ -1020,6 +1020,7 @@ static __init int nx842_powernv_init(void) ret = nx842_powernv_probe_vas(dn); if (ret) { nx842_delete_coprocs(); + of_node_put(dn); return ret; } }