| Message ID | 20190718050604.74233-2-aik@ozlabs.ru (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | powerpc/xive: Drop deregistered irqs | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (f5c20693d8edcd665f1159dc941b9e7f87c17647) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 25 lines checked |
diff --git a/arch/powerpc/include/asm/machdep.h b/arch/powerpc/include/asm/machdep.h index c43d6eca9edd..6cc14e28e89a 100644 --- a/arch/powerpc/include/asm/machdep.h +++ b/arch/powerpc/include/asm/machdep.h @@ -59,6 +59,9 @@ struct machdep_calls { /* Return an irq, or 0 to indicate there are none pending. */ unsigned int (*get_irq)(void); + /* Drops irq if it does not have a valid descriptor */ + void (*orphan_irq)(unsigned int irq); + /* PCI stuff */ /* Called after allocating resources */ void (*pcibios_fixup)(void); diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c index 5645bc9cbc09..e0689dcb17f0 100644 --- a/arch/powerpc/kernel/irq.c +++ b/arch/powerpc/kernel/irq.c @@ -632,10 +632,13 @@ void __do_irq(struct pt_regs *regs) may_hard_irq_enable(); /* And finally process it */ - if (unlikely(!irq)) + if (unlikely(!irq)) { __this_cpu_inc(irq_stat.spurious_irqs); - else - generic_handle_irq(irq); + } else if (generic_handle_irq(irq)) { + if (ppc_md.orphan_irq) + ppc_md.orphan_irq(irq); + __this_cpu_inc(irq_stat.spurious_irqs); + } trace_irq_exit(regs);
The test on generic_handle_irq() catches interrupt events that were served on a target CPU while the source interrupt was being shutdown on another CPU. This may lead to a blocked interrupt queue on a target CPU so if there is another assigned irq on that CPU, that device stops working. This adds necessary infrastructure to allow platform to deal with it. The next patch implements it for XIVE. Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> --- arch/powerpc/include/asm/machdep.h | 3 +++ arch/powerpc/kernel/irq.c | 9 ++++++--- 2 files changed, 9 insertions(+), 3 deletions(-)