diff mbox series

powerpc: remote save_stack_trace_tsk_reliable export

Message ID 20190301191721.4010-1-joe.lawrence@redhat.com (mailing list archive)
State Accepted
Commit 39070a96a1c2c502b2f77972ba8c2eba3ca6cd3a
Headers show
Series powerpc: remote save_stack_trace_tsk_reliable export | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success next/apply_patch Successfully applied
snowpatch_ozlabs/build-ppc64le warning build succeeded but added 103 new sparse warning(s)
snowpatch_ozlabs/build-ppc64be warning build succeeded but added 103 new sparse warning(s)
snowpatch_ozlabs/build-ppc64e warning build succeeded but added 1 new sparse warning(s)
snowpatch_ozlabs/build-pmac32 warning build succeeded but added 18 new sparse warning(s)
snowpatch_ozlabs/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked

Commit Message

Joe Lawrence March 1, 2019, 7:17 p.m. UTC
As tglx points out, there are no in-tree module users of
save_stack_trace_tsk_reliable() and its x86 counterpart is not exported,
so remove the powerpc symbol export.

Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
---
 arch/powerpc/kernel/stacktrace.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Balbir Singh March 3, 2019, 8:05 p.m. UTC | #1
On 3/1/19 11:17 AM, Joe Lawrence wrote:
> As tglx points out, there are no in-tree module users of
> save_stack_trace_tsk_reliable() and its x86 counterpart is not exported,
> so remove the powerpc symbol export.
> 
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> ---
>  arch/powerpc/kernel/stacktrace.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
> index e2c50b55138f..42c587de21a9 100644
> --- a/arch/powerpc/kernel/stacktrace.c
> +++ b/arch/powerpc/kernel/stacktrace.c
> @@ -193,7 +193,6 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk,
>  	}
>  	return 0;
>  }
> -EXPORT_SYMBOL_GPL(save_stack_trace_tsk_reliable);
>  #endif /* CONFIG_HAVE_RELIABLE_STACKTRACE */
>  
>  #if defined(CONFIG_PPC_BOOK3S_64) && defined(CONFIG_NMI_IPI)
> 


Acked-by: Balbir Singh <bsingharora@gmail.com>

Balbir Singh
diff mbox series

Patch

diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
index e2c50b55138f..42c587de21a9 100644
--- a/arch/powerpc/kernel/stacktrace.c
+++ b/arch/powerpc/kernel/stacktrace.c
@@ -193,7 +193,6 @@  save_stack_trace_tsk_reliable(struct task_struct *tsk,
 	}
 	return 0;
 }
-EXPORT_SYMBOL_GPL(save_stack_trace_tsk_reliable);
 #endif /* CONFIG_HAVE_RELIABLE_STACKTRACE */
 
 #if defined(CONFIG_PPC_BOOK3S_64) && defined(CONFIG_NMI_IPI)