| Message ID | 20180802153951.3576-1-npiggin@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3127692deba6eeb7ed6d416b25e91f179e17be8f |
| Headers | show |
| Series | powernv/cpuidle: Fix idle states all being marked invalid | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/checkpatch | fail | Test checkpatch on branch next |
| snowpatch_ozlabs/build-ppc64le | success | Test build-ppc64le on branch next |
| snowpatch_ozlabs/build-ppc64be | success | Test build-ppc64be on branch next |
| snowpatch_ozlabs/build-ppc64e | success | Test build-ppc64e on branch next |
| snowpatch_ozlabs/build-ppc32 | success | Test build-ppc32 on branch next |
On Fri, Aug 03, 2018 at 01:39:51AM +1000, Nicholas Piggin wrote: > Commit 9c7b185ab2 ("powernv/cpuidle: Parse dt idle properties into > global structure") parses dt idle states into structs, but never > marks them valid. This results in all idle states being lost. > My bad. Thanks nick for fixing this. We definatetely need this. > Cc: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com> > Cc: Gautham R. Shenoy <ego@linux.vnet.ibm.com> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Acked-by: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com> > --- > arch/powerpc/platforms/powernv/idle.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c > index 3116bab10aa3..ecb002c5db83 100644 > --- a/arch/powerpc/platforms/powernv/idle.c > +++ b/arch/powerpc/platforms/powernv/idle.c > @@ -651,11 +651,12 @@ static int __init pnv_power9_idle_init(void) > &state->psscr_mask, > state->flags); > if (err) { > - state->valid = false; > report_invalid_psscr_val(state->psscr_val, err); > continue; > } > > + state->valid = true; > + > if (max_residency_ns < state->residency_ns) { > max_residency_ns = state->residency_ns; > pnv_deepest_stop_psscr_val = state->psscr_val; > -- > 2.17.0 >
On Thu, 2018-08-02 at 15:39:51 UTC, Nicholas Piggin wrote: > Commit 9c7b185ab2 ("powernv/cpuidle: Parse dt idle properties into > global structure") parses dt idle states into structs, but never > marks them valid. This results in all idle states being lost. > > Cc: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com> > Cc: Gautham R. Shenoy <ego@linux.vnet.ibm.com> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > Acked-by: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/3127692deba6eeb7ed6d416b25e91f cheers
diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c index 3116bab10aa3..ecb002c5db83 100644 --- a/arch/powerpc/platforms/powernv/idle.c +++ b/arch/powerpc/platforms/powernv/idle.c @@ -651,11 +651,12 @@ static int __init pnv_power9_idle_init(void) &state->psscr_mask, state->flags); if (err) { - state->valid = false; report_invalid_psscr_val(state->psscr_val, err); continue; } + state->valid = true; + if (max_residency_ns < state->residency_ns) { max_residency_ns = state->residency_ns; pnv_deepest_stop_psscr_val = state->psscr_val;
Commit 9c7b185ab2 ("powernv/cpuidle: Parse dt idle properties into global structure") parses dt idle states into structs, but never marks them valid. This results in all idle states being lost. Cc: Akshay Adiga <akshay.adiga@linux.vnet.ibm.com> Cc: Gautham R. Shenoy <ego@linux.vnet.ibm.com> Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- arch/powerpc/platforms/powernv/idle.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)