From patchwork Fri May 4 17:19:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 908898 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40czTb0Qfdz9s35 for ; Sat, 5 May 2018 03:26:59 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bSphO+cZ"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 40czTZ62DYzDrK4 for ; Sat, 5 May 2018 03:26:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bSphO+cZ"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c00::244; helo=mail-pf0-x244.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bSphO+cZ"; dkim-atps=neutral Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40czKR1L54zDqjk for ; Sat, 5 May 2018 03:19:55 +1000 (AEST) Received: by mail-pf0-x244.google.com with SMTP id e9so13934979pfi.4 for ; Fri, 04 May 2018 10:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=46FPLaarHG1cGN4XnnfGMXeeah5o1fj6lv+pKaROkag=; b=bSphO+cZ66hR0fCEFs95it92kOflqLkt1OghYxsMBYb+0wY+VJCdzZHJ27TMKOp9j7 WL5tsW7CGrxdpOJ0by9EBIaIMngt61QV/vDjssCtDQhFOySFgNc0CHCZaNLtZS9i99k9 SQpfMV934Jr9m5m59k2/fS280OjsCil2rL6nsa7sc7bt8IT5L+N5f5v5cPVXHnyQK1xc Q9K4fZVfMrJ9NnTtn2CsmIWInSZkoIUfimd6aCyBQF9FMGr7nKKwbHqmFn3v36KmMuQh 0YcgTtfWE73Qd092BfHB+OLIgdHKfMwlfnuMkkV5A7/8oIVxoAR8Z2OrLE9vXo9jlhSx JFBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=46FPLaarHG1cGN4XnnfGMXeeah5o1fj6lv+pKaROkag=; b=nMb9EpColxvLBbMTAL2L/kPto/eya419TzSErfYvUAFNa0JRtzUUFfVn1ASeeY3Qy4 Hq7C9pOOl1zT/ctXsBDklTZYhKZwYen3z2QF1Mx2XvL0GkhmxjT/fQZNX3VvMdHJ0RJ2 d0ziKVzNMlft5YGsWWQpwB/r/YXV/8HrRtK7qGwrraIIYbqueTWLd9lutKxWLhA/iIJj maqNqMPDiFHKI2DT07lOz4u0AYShIyvQdNs/xL6cJw4y+kVW+0L+gJcYE025ieHQtzMS JvGJ2aWdQb8JNR6hKhnYCEhOVtXdlDVrGMFK73QTmQUeEFssrrkaTG1kQWAXLNtjP7ox DHzg== X-Gm-Message-State: ALQs6tD01cv21AH/mCEJpSVZDBkk2p6ZJ2nl/U+4+b0ZpqLBSH24Ys0n YKn3KdtIwk2/00crj+q8T11pJw== X-Google-Smtp-Source: AB8JxZpNhuDiy2ETh15xwPfvI0+eGoxX7OdZvMWvnU3tZ9exR8A36yduSQPTVjqkpxAz/QEqvM+fmw== X-Received: by 2002:a17:902:462:: with SMTP id 89-v6mr28253443ple.300.1525454392989; Fri, 04 May 2018 10:19:52 -0700 (PDT) Received: from roar.au.ibm.com (59-102-70-78.tpgi.com.au. [59.102.70.78]) by smtp.gmail.com with ESMTPSA id u16sm29890009pfl.39.2018.05.04.10.19.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 May 2018 10:19:52 -0700 (PDT) From: Nicholas Piggin To: linuxppc-dev@lists.ozlabs.org Subject: [PATCH 02/11] powerpc/pseries: put cede MSR[EE] check under IRQ_SOFT_MASK_DEBUG Date: Sat, 5 May 2018 03:19:26 +1000 Message-Id: <20180504171935.25410-3-npiggin@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180504171935.25410-1-npiggin@gmail.com> References: <20180504171935.25410-1-npiggin@gmail.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicholas Piggin Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" This check does not catch IRQ soft mask bugs, but this option is slightly more suitable than TRACE_IRQFLAGS. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/plpar_wrappers.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/include/asm/plpar_wrappers.h b/arch/powerpc/include/asm/plpar_wrappers.h index 96c1a46acbd0..cff5a411e595 100644 --- a/arch/powerpc/include/asm/plpar_wrappers.h +++ b/arch/powerpc/include/asm/plpar_wrappers.h @@ -39,10 +39,10 @@ static inline long extended_cede_processor(unsigned long latency_hint) set_cede_latency_hint(latency_hint); rc = cede_processor(); -#ifdef CONFIG_TRACE_IRQFLAGS - /* Ensure that H_CEDE returns with IRQs on */ - if (WARN_ON(!(mfmsr() & MSR_EE))) - __hard_irq_enable(); +#ifdef CONFIG_PPC_IRQ_SOFT_MASK_DEBUG + /* Ensure that H_CEDE returns with IRQs on */ + if (WARN_ON(!(mfmsr() & MSR_EE))) + __hard_irq_enable(); #endif set_cede_latency_hint(old_latency_hint);