From patchwork Wed Apr 4 20:09:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mathieu Malaterre X-Patchwork-Id: 895143 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40Gcff6zYnz9ryr for ; Thu, 5 Apr 2018 06:16:10 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QfzKajcq"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 40Gcff55NFzDrnp for ; Thu, 5 Apr 2018 06:16:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QfzKajcq"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=mathieu.malaterre@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QfzKajcq"; dkim-atps=neutral Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40GcVl0QwTzF1pH for ; Thu, 5 Apr 2018 06:09:18 +1000 (AEST) Received: by mail-wm0-x241.google.com with SMTP id r131so435657wmb.2 for ; Wed, 04 Apr 2018 13:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ywjICHv4xpADuX6+xLMVqn50beU+uwBI5GqtUqHyvJk=; b=QfzKajcq7hYgnexTfs9/1lzrnM7qIx6tG1IdOiBtKvd6F5KawMCkmmux73hrZTDiqc TD/si+WdatknddAFKsqagM0lR3GJMswVWJ+NWG2RydFmB66SpDqymujL29y5deGkUnj9 DI4fUlezm9QrZAzd6HUapQCSc52xbaguFH5KTJYLwvEnUyLp30sCk0fj/B8ZNG7PeiXn NzgChsZ3mhY5StBg/023f3gOiysV5f3fXDbqJQkzT2vOtq7MTleqjwOseBh+YmlJiQv+ hYXAaCq2beEMxCqJV1MAR9X17JPuVCgYh9fB4AqULv1qgE6hy1SeU09Rgy9sjmLd1XTx EjcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ywjICHv4xpADuX6+xLMVqn50beU+uwBI5GqtUqHyvJk=; b=oWQksBKSv22ZNzHZx96RJ5QntS1kicZ91+7hj2RfWAuC0SvDQaHOfwXmQOMcat4Wzy 9d5iJ2WeCKaW0lu5kbFb12ALf+SzRKvs/wTwaK0Hro1b7yYzxU+j6o0dKaIeYU+L9saQ nzh1JDmN4nGVMiJqwR1y5dEVCOyD4/ZcA+EgQpWDkbXjm1tA7QXUIyLm0FmcRPdXRvdX U5v0p/yv+KAIuixZaYOFHaXzTMJEgVlMUOOi6d9moOweW+MVkZ9fFWlyijL3zF25ha7k hG9QB2AEnU9qUPqMLhG3bZA2+kRroG89MXEUaN08Hv5T/RsTho2Y/O3oq+JuK9GR9Mgo wVWw== X-Gm-Message-State: ALQs6tBnzLlhRTjJ+mbgtN73nurItLsIuGapzo2BLrTODACw50j5cNBm yKdLiLVgS+T1py53W4aQitI= X-Google-Smtp-Source: AIpwx4/JU5tNRo8bzJv3xZq6eR7YNKVuAFIhoTJwRbHLnWUolK5VYoj3neoyIx6N5AXbTkSuQJ1DIg== X-Received: by 10.28.135.195 with SMTP id j186mr9098753wmd.143.1522872555817; Wed, 04 Apr 2018 13:09:15 -0700 (PDT) Received: from macbookpro.malat.net (bru31-1-78-225-226-121.fbx.proxad.net. [78.225.226.121]) by smtp.gmail.com with ESMTPSA id n21sm6461809wmi.37.2018.04.04.13.09.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Apr 2018 13:09:15 -0700 (PDT) Received: by macbookpro.malat.net (Postfix, from userid 1000) id EEDF210C0572; Wed, 4 Apr 2018 22:09:12 +0200 (CEST) From: Mathieu Malaterre To: Michael Ellerman Subject: [PATCH v3 05/19] powerpc/chrp/setup: Remove idu_size variable and make some functions static Date: Wed, 4 Apr 2018 22:09:11 +0200 Message-Id: <20180404200911.27506-1-malat@debian.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180328193553.1122-1-malat@debian.org> References: <20180328193553.1122-1-malat@debian.org> MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Malaterre , linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Remove variable declaration idu_size and associated code since not used. These functions can all be static, make it so. Fix warnings treated as errors with W=1: arch/powerpc/platforms/chrp/setup.c:97:6: error: no previous prototype for ‘chrp_show_cpuinfo’ [-Werror=missing-prototypes] arch/powerpc/platforms/chrp/setup.c:302:13: error: no previous prototype for ‘chrp_setup_arch’ [-Werror=missing-prototypes] arch/powerpc/platforms/chrp/setup.c:385:16: error: variable ‘idu_size’ set but not used [-Werror=unused-but-set-variable] arch/powerpc/platforms/chrp/setup.c:526:13: error: no previous prototype for ‘chrp_init_IRQ’ [-Werror=missing-prototypes] arch/powerpc/platforms/chrp/setup.c:559:1: error: no previous prototype for ‘chrp_init2’ [-Werror=missing-prototypes] Suggested-by: Christophe Leroy Signed-off-by: Mathieu Malaterre --- v3: update subject line after v2 change v2: Remove totally variable idu_size arch/powerpc/platforms/chrp/setup.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/platforms/chrp/setup.c b/arch/powerpc/platforms/chrp/setup.c index 481ed133e04b..d6d8ffc0271e 100644 --- a/arch/powerpc/platforms/chrp/setup.c +++ b/arch/powerpc/platforms/chrp/setup.c @@ -94,7 +94,7 @@ static const char *chrp_names[] = { "Total Impact Briq" }; -void chrp_show_cpuinfo(struct seq_file *m) +static void chrp_show_cpuinfo(struct seq_file *m) { int i, sdramen; unsigned int t; @@ -299,7 +299,7 @@ static __init void chrp_init(void) of_node_put(node); } -void __init chrp_setup_arch(void) +static void __init chrp_setup_arch(void) { struct device_node *root = of_find_node_by_path("/"); const char *machine = NULL; @@ -382,7 +382,7 @@ static void __init chrp_find_openpic(void) { struct device_node *np, *root; int len, i, j; - int isu_size, idu_size; + int isu_size; const unsigned int *iranges, *opprop = NULL; int oplen = 0; unsigned long opaddr; @@ -427,11 +427,9 @@ static void __init chrp_find_openpic(void) } isu_size = 0; - idu_size = 0; if (len > 0 && iranges[1] != 0) { printk(KERN_INFO "OpenPIC irqs %d..%d in IDU\n", iranges[0], iranges[0] + iranges[1] - 1); - idu_size = iranges[1]; } if (len > 1) isu_size = iranges[3]; @@ -523,7 +521,7 @@ static void __init chrp_find_8259(void) } } -void __init chrp_init_IRQ(void) +static void __init chrp_init_IRQ(void) { #if defined(CONFIG_VT) && defined(CONFIG_INPUT_ADBHID) && defined(CONFIG_XMON) struct device_node *kbd; @@ -555,7 +553,7 @@ void __init chrp_init_IRQ(void) #endif } -void __init +static void __init chrp_init2(void) { #ifdef CONFIG_NVRAM