From patchwork Sun Apr 1 10:36:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 893978 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40DX5p1GxJz9s1c for ; Sun, 1 Apr 2018 20:43:58 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RJjKxJzn"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 40DX5n6pYVzF1x5 for ; Sun, 1 Apr 2018 20:43:57 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RJjKxJzn"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c01::244; helo=mail-pl0-x244.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RJjKxJzn"; dkim-atps=neutral Received: from mail-pl0-x244.google.com (mail-pl0-x244.google.com [IPv6:2607:f8b0:400e:c01::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40DWxJ2zW3zF21n for ; Sun, 1 Apr 2018 20:36:36 +1000 (AEST) Received: by mail-pl0-x244.google.com with SMTP id m22-v6so2540609pls.5 for ; Sun, 01 Apr 2018 03:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sMFfbUtjL/zilH+QwP1ZUkWNjVmPsrSKEn3P37KsuvQ=; b=RJjKxJznw/E5WRaZDrdXgB9caPzfoA9I62jdEdBg4FAkobP6L1VbGNwJck6ACFdCCK rpES7Js7FYtwBDq72M1rwNaZ+SdGl6an/Coi6acIUnx9C1dy7eT6WbZD3BNDQVAeSg+n jBSzcYnagkNu0of9GB56Tqqzo5ZwJzC18uQ9nKH1sNWveGAz3ntR/vV9HuU0fzNgr3jw dzolQj1/3pfIjpZp028FAy7TBcoo127o6rDeA2th02OCTvkYtSDAHy6SCsKfAhtOS+Tf hxbPUVYCJC97jl6fQU03cXpXt3c+xwEQ1FHAUQLgtfpEUomd7rsBrgs375ePu+a26vnd Hqfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sMFfbUtjL/zilH+QwP1ZUkWNjVmPsrSKEn3P37KsuvQ=; b=HTURKFgu8FtI2GB2kFhS7SZctX3KYLo8I6S+HvKAiHdEnYpjAyUS0BTqNDH4pfyT5r Or7qtXQ4POCDw1N44aZsjyNiWxu5WMPkTLfLcHcExoK8zoqVdJ7igkspmAZIoVYSNLUN kv2aP8Rbq8noscqBdtimitIPeNZ5+eQOb8t4rEU54pVDpSlXRK9zqHcxX1dseye3zBu+ 0x4+TKpAUiDXLdjnujqEq1xbqTyUizZxH471qA+i0YcXbXD/LDUM+2W/da5RPiDqy1sZ Ua/n5jlvAsare4KVcg0VDylgAVXgilNxft0hFSDiM1GJlFFqmkKU5JkHu8STECW4Sy8u gaOg== X-Gm-Message-State: AElRT7EuZZpLMN40TYgczse07QGqmDS0XH6VD28uNz6bGP6P92Jcb+VJ jRzcKHJjeyTVno3etJ+uYtvrRw== X-Google-Smtp-Source: AIpwx49BslXU+jWXLBi+bgyW9GM5ZVE5VZ1I4RVQ7MQ4GhDN++MQOvgHtIzb5o/K9WqQ0wojdAppog== X-Received: by 2002:a17:902:7401:: with SMTP id g1-v6mr5967931pll.4.1522578994538; Sun, 01 Apr 2018 03:36:34 -0700 (PDT) Received: from roar.au.ibm.com (59-102-70-78.tpgi.com.au. [59.102.70.78]) by smtp.gmail.com with ESMTPSA id d83sm26977486pfl.176.2018.04.01.03.36.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Apr 2018 03:36:33 -0700 (PDT) From: Nicholas Piggin To: linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2 2/3] powerpc: hard disable irqs in smp_send_stop loop Date: Sun, 1 Apr 2018 20:36:14 +1000 Message-Id: <20180401103615.15454-3-npiggin@gmail.com> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180401103615.15454-1-npiggin@gmail.com> References: <20180401103615.15454-1-npiggin@gmail.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vasant Hegde , Nicholas Piggin Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" The hard lockup watchdog can fire under local_irq_disable on platforms with irq soft masking. Signed-off-by: Nicholas Piggin --- arch/powerpc/kernel/smp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index db88660bf6bd..e16ec7b3b427 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc/kernel/smp.c @@ -574,9 +574,10 @@ static void stop_this_cpu(void *dummy) /* Remove this CPU */ set_cpu_online(smp_processor_id(), false); - local_irq_disable(); + hard_irq_disable(); + spin_begin(); while (1) - ; + spin_cpu_relax(); } void smp_send_stop(void)