diff mbox series

[v4,2/5] powerpc/mce: align the print of physical address better

Message ID 20170929042655.14570-3-bsingharora@gmail.com (mailing list archive)
State Accepted
Commit 81b61fa7a065e639d097b09c303e3212e4264fac
Headers show
Series Revisit MCE handling for UE Errors | expand

Commit Message

Balbir Singh Sept. 29, 2017, 4:26 a.m. UTC 
Use the same alignment as Effective address and rename
phyiscal address to Page Frame Number

Signed-off-by: Balbir Singh <bsingharora@gmail.com>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
---
 arch/powerpc/kernel/mce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Ellerman Oct. 16, 2017, 5:18 a.m. UTC | #1 
Balbir Singh <bsingharora@gmail.com> writes:

> Use the same alignment as Effective address
> and rename phyiscal address to Page Frame Number

You didn't do the 2nd part AFAICS?

Will fix it up.

cheers

> diff --git a/arch/powerpc/kernel/mce.c b/arch/powerpc/kernel/mce.c
> index e254399..fef1408 100644
> --- a/arch/powerpc/kernel/mce.c
> +++ b/arch/powerpc/kernel/mce.c
> @@ -340,7 +340,7 @@ void machine_check_print_event_info(struct machine_check_event *evt,
>  			printk("%s    Effective address: %016llx\n",
>  			       level, evt->u.ue_error.effective_address);
>  		if (evt->u.ue_error.physical_address_provided)
> -			printk("%s      Physical address: %016llx\n",
> +			printk("%s    Physical address:  %016llx\n",
>  			       level, evt->u.ue_error.physical_address);
>  		break;
>  	case MCE_ERROR_TYPE_SLB:
> -- 
> 2.9.5
Balbir Singh Oct. 16, 2017, 5:36 a.m. UTC | #2 
On Mon, Oct 16, 2017 at 4:18 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Balbir Singh <bsingharora@gmail.com> writes:
>
>> Use the same alignment as Effective address
>> and rename phyiscal address to Page Frame Number
>
> You didn't do the 2nd part AFAICS?
>
> Will fix it up.

Sorry the changelog is buggy :( Nick asked me to keep the physical address.
I should have removed the changes when I reverted the changes

Balbir
diff mbox series

Patch

diff --git a/arch/powerpc/kernel/mce.c b/arch/powerpc/kernel/mce.c
index e254399..fef1408 100644
--- a/arch/powerpc/kernel/mce.c
+++ b/arch/powerpc/kernel/mce.c
@@ -340,7 +340,7 @@  void machine_check_print_event_info(struct machine_check_event *evt,
 			printk("%s    Effective address: %016llx\n",
 			       level, evt->u.ue_error.effective_address);
 		if (evt->u.ue_error.physical_address_provided)
-			printk("%s      Physical address: %016llx\n",
+			printk("%s    Physical address:  %016llx\n",
 			       level, evt->u.ue_error.physical_address);
 		break;
 	case MCE_ERROR_TYPE_SLB: