From patchwork Fri Mar 10 02:33:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 737232 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vfWZg441Cz9s7c for ; Fri, 10 Mar 2017 13:35:23 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MNl09nGi"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3vfWZg30v6zDqZC for ; Fri, 10 Mar 2017 13:35:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MNl09nGi"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-oi0-x242.google.com (mail-oi0-x242.google.com [IPv6:2607:f8b0:4003:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vfWY73f7nzDqXh for ; Fri, 10 Mar 2017 13:34:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MNl09nGi"; dkim-atps=neutral Received: by mail-oi0-x242.google.com with SMTP id 2so5874928oif.0 for ; Thu, 09 Mar 2017 18:34:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=yBYGN07x+bKec+0mt0dlpVVqWdexNyX8PLTcp7acSwE=; b=MNl09nGiFO1ICPOOxmbCqLQwn5B+ADqOvZDDRpo6tAVA2vdF+1eZvaT7q9NvKXwQ9l xsryw6G12+TAn7RV4yBQf40w8wEky8eD7yTqOmg/ZklQXVpn6TzxW16BthLiZXBUgmUE RbyMLK++Wm8m7JcTajhYA9e4L+N8UWowK0cGTzgq5/lC6qEvdPKMe3R4/C/lcswEHLGi 1hplGpj664NQYu7ZW6KIa7leBuTxOtCgSiYKVzDoQeiTUFAMLGhA96vmNAeyjcV0LNdc Y0VH+Xk9t16m/BNzNcBnnzCnjSJnFE8VOAfpiQuobyhs5lt4Pywk2KDa7rU61M9S7xe3 VGfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=yBYGN07x+bKec+0mt0dlpVVqWdexNyX8PLTcp7acSwE=; b=ojX2GvYzaV9hIWRrRWa36tpGKqWATtNOQdi88u0pir1dU3LqAydi8VqY3V5Wv9penD ihfy9fcLA2x1Un56HXPIIJuX6r6t5mFxOoSlxEQH2rHovjjlwC43h8yjvkGF3ymcN5z1 tRS+hleqj+p/WNpGCCqA8TJnVuqoPgPCZ6Srmi/Rhicls0/DDrQaaHtKHnjzR6BZV5eY 4SqNWCW/e0DHqb3Vg0m9LuRqs6ktB9g6I23z9FuG09eS6hYcjRAIh7aEMtb7rFbJpoH7 r/yp0GW8tVUofc9qNw2SmDQXOxo1pKnCdZluhTwaeufOmLoiZG7chOtLBdhrl4OrT3aP ynEA== X-Gm-Message-State: AMke39n9hUYm1hxzxbh49aIQPJXU0pXEGoyDVSIU9dKnNuAzaKDJFWqgubXX183DRumpqg== X-Received: by 10.202.175.73 with SMTP id y70mr8592920oie.174.1489113241011; Thu, 09 Mar 2017 18:34:01 -0800 (PST) Received: from linux-4v1g.suse (cpe-24-31-249-175.kc.res.rr.com. [24.31.249.175]) by smtp.gmail.com with ESMTPSA id j61sm3694041otc.22.2017.03.09.18.33.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Mar 2017 18:34:00 -0800 (PST) From: Larry Finger To: Linus Torvalds Subject: [PATCH] powerpc: Fix crash introduced with commit 5657933dbb6e Date: Thu, 9 Mar 2017 20:33:51 -0600 Message-Id: <20170310023351.973-1-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.10.2 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "regressions @ leemhuis . info" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Larry Finger Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Code inserted during the code merged between kernels 4.10 and 4.11-rc1 caused an early panic quickly followed by a complete shutdown for PowerPC. The traceback was not displayed long enough to read or photograph, thus it is not reproduced here. The problem was bisected to commit 5657933dbb6e ("treewide: Move dma_ops from struct dev_archdata into struct device"). The problem was a missing copy of critical information from struct dev_archdata into struct device, leading to the dereference of a null pointer. This fix was suggested by Benjamin Herrenschmidt. Fixes: commit 5657933dbb6e ("treewide: Move dma_ops from struct dev_archdata into struct device") Signed-off-by: Larry Finger Cc: linuxppc-dev@lists.ozlabs.org Cc: Benjamin Herrenschmidt Cc: regressions@leemhuis.info drivers/macintosh/macio_asic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c index 3f041b1..f757cef2 100644 --- a/drivers/macintosh/macio_asic.c +++ b/drivers/macintosh/macio_asic.c @@ -392,6 +392,7 @@ static struct macio_dev * macio_add_one_device(struct macio_chip *chip, * To get all the fields, copy all archdata */ dev->ofdev.dev.archdata = chip->lbus.pdev->dev.archdata; + dev->ofdev.dev.dma_ops = chip->lbus.pdev->dev.dma_ops; #endif /* CONFIG_PCI */ #ifdef DEBUG