From patchwork Fri Dec 23 03:06:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 708375 X-Patchwork-Delegate: scottwood@freescale.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tlCyS1mMkz9sf9 for ; Fri, 23 Dec 2016 14:08:32 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="sfvQolH4"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3tlCyS0YRKzDwNN for ; Fri, 23 Dec 2016 14:08:32 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="sfvQolH4"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-oi0-x243.google.com (mail-oi0-x243.google.com [IPv6:2607:f8b0:4003:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tlCwt2TCGzDwKh for ; Fri, 23 Dec 2016 14:07:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="sfvQolH4"; dkim-atps=neutral Received: by mail-oi0-x243.google.com with SMTP id u15so34951340oie.3 for ; Thu, 22 Dec 2016 19:07:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=w7hjmgAWfdaGYr3A2Ubxi2H+TXpRlvIcnsBPJUC1kpI=; b=sfvQolH4lr4hjotf+Pa33OrMxpKAKSmpPeuLkgbfOArreCS2l5KFmvapK9tjyt3wdU /pNYjhx+ZkjjvdoTdSaOACVEAfnb0or+/yR9wWrrFKnHv9JR3q8XwzkZnLo3eQDUakYq vAwclpO5iUUw8UvuJ/hw8Xw8erbUSJlzwU3wTNIFrAry2MeTdjaeooJ5bzInOt6pIbNw Zxuxv+IGtXCoHNGjMuaCtJlq7Guzg/7gCFqKR2nKutACXnK57krbrES82go+L/6ws2JQ ZPZZlE3YlXuELVpIvbycrDmV7V3yTksMBFRekQLAWmID62ARaN2RR922/ziZGanyJtNt /Xng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=w7hjmgAWfdaGYr3A2Ubxi2H+TXpRlvIcnsBPJUC1kpI=; b=iXv6F/9+p9QBdJ527Y2cqC4JFvUhOw8sq+/G+tJqFchvw54EmloGUS1ComEoJrt9c/ lEhDgOXl3HeD6YXxsjXKoxnI7f8AaZzjwjyRQ59bm52xUqpT1KhL8OxtFpTwzu6t0Tyf DxBBy/Uh/OK2Kod+9TPRnWyVafEnnw7OwYVylZDH13UxAIvo1PDSJQyJmeHTAxed8VW3 1LWqUNqzUpap9KV6oRgCOqmbA3HMTI/5Urz9/XLztcy2Fp1Gz6oaSPDAsJoVg1EYz/s3 yKxLGj4g4P6DGUj/COHihX+9D8YumLeeu73eSVOF8Bok6S8wXL3pJublT25nWhKsJkM+ ZD5g== X-Gm-Message-State: AIkVDXKTX1qow/aicpiQt2cpxn9ytee5/UExZD1Cp1fh7hvQ/MIrd7xoObaWSUlg9HqpOQ== X-Received: by 10.157.21.104 with SMTP id z37mr6373141otz.93.1482462428152; Thu, 22 Dec 2016 19:07:08 -0800 (PST) Received: from linux-4v1g.suse (cpe-24-31-249-175.kc.res.rr.com. [24.31.249.175]) by smtp.gmail.com with ESMTPSA id v76sm14929985oie.27.2016.12.22.19.07.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 22 Dec 2016 19:07:07 -0800 (PST) From: Larry Finger To: Linus Torvalds Subject: [PATCH] powerpc: Fix build warning on 32-bit PPC - bisected to commit 989cea5c14be Date: Thu, 22 Dec 2016 21:06:53 -0600 Message-Id: <20161223030653.30178-1-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.10.2 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Nicholas Piggin , driver-devel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Larry Finger Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" I am getting the following warning when I build kernel 4.9-git on my PowerBook G4 with a 32-bit PPC processor: AS arch/powerpc/kernel/misc_32.o arch/powerpc/kernel/misc_32.S:299:7: warning: "CONFIG_FSL_BOOKE" is not defined [-Wundef] This problem is evident after commit 989cea5c14be ("kbuild: prevent lib-ksyms.o rebuilds"); however, this change in kbuild only exposes an error that has been in the code since 2005 when this source file was created. That was with commit 9994a33865f4 ("powerpc: Introduce entry_{32,64}.S, misc_{32,64}.S, systbl.S"). The offending line is way does not make a lot of sense. This error does not seem to cause any errors in the executable, thus I am not recommending that it be applied to any stable versions. Thanks to Nicholas Piggin for suggesting this solution. Fixes: 9994a33865f4 ("powerpc: Introduce entry_{32,64}.S, misc_{32,64}.S, systbl.S") Signed-off-by: Larry Finger Cc: Nicholas Piggin Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/kernel/misc_32.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S index 1863324..84db14e 100644 --- a/arch/powerpc/kernel/misc_32.S +++ b/arch/powerpc/kernel/misc_32.S @@ -296,7 +296,7 @@ _GLOBAL(flush_instruction_cache) lis r3, KERNELBASE@h iccci 0,r3 #endif -#elif CONFIG_FSL_BOOKE +#elif defined(CONFIG_FSL_BOOKE) BEGIN_FTR_SECTION mfspr r3,SPRN_L1CSR0 ori r3,r3,L1CSR0_CFI|L1CSR0_CLFC