From patchwork Mon Oct 10 13:02:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejun Heo X-Patchwork-Id: 680393 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3st0h76BSkz9s65 for ; Tue, 11 Oct 2016 00:04:23 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=LhwZ6R+z; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3st0h75CZFzDsnS for ; Tue, 11 Oct 2016 00:04:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=LhwZ6R+z; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-oi0-x241.google.com (mail-oi0-x241.google.com [IPv6:2607:f8b0:4003:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3st0fd4z7yzDrbq for ; Tue, 11 Oct 2016 00:03:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=LhwZ6R+z; dkim-atps=neutral Received: by mail-oi0-x241.google.com with SMTP id e12so1232857oib.3 for ; Mon, 10 Oct 2016 06:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PPqfJjXM47QXaTYOt4+A1hzUIYT1xX0NK1+zEfuBvuk=; b=LhwZ6R+zXQ2EoQj4Yn81WL/8IH3pZwMCj+GGJqY0/LCLnM5Ioel64Rlv9APOH3C7OT PBIgSmll8jShw7k/dh5SvAJQC1070sgnxHy2dodqxCiHQH8bEO58safuGRJN+XcORUvF fS+MRTf4BFfI05YWejxYFLAsL1XGNtwbwUsSKBEz7WMvRBAYz7jTjpb3xs84RyWPb25n H9AWR72N9ukruDcEXIuFAN44SNscNWxOhN1PnKGWWL1JsaLY5rHh5ae5i0ekMQDwhayn ZJsy3YoNjzO6jP7k3U9nixS7vA68Vl2HTrnIDeveT+VaqflFWg8WvnVM/hjicTxBHB0H adhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=PPqfJjXM47QXaTYOt4+A1hzUIYT1xX0NK1+zEfuBvuk=; b=fB8yr0zxt9vhy/wPT+VawroUPsbA3Wcbgw0hvYXsCuaZRTRtvfhgLR+6Inpvb/C3IF YeUfKBz5cBT6ExSfnAgx0ooXOOOLwzTXn6LX301+I1meMK5YQ8ijSR75rXH6QJwP36la IE9IxZwasRHVSsZyQXyXntFzx+R4Ls5stnlKTLDsGJCLmDJz5nmsQvf5EdtpUazPbNge lSAz9WC/DgYUc/0d+m/WdLbA2BOaS8Y3O4fkkISIm5d8EIH3yscUShN3XZp4I7FTse27 cs2k1IyBa/F7P9X7eEGIvh4TqA+ZBEnS+MQYyVmnx6jdEqnYHri3XuGRf2VxiXbJIzkm H2Bg== X-Gm-Message-State: AA6/9RlVy4ATWS4f2uyfV570vO0wbJZcDTgzhe3Jx5Nl63ktT1XhfIVuHJx3ozdYnDIVTw== X-Received: by 10.202.74.197 with SMTP id x188mr25001445oia.155.1476104583500; Mon, 10 Oct 2016 06:03:03 -0700 (PDT) Received: from localhost ([75.104.69.31]) by smtp.gmail.com with ESMTPSA id a62sm7276875oic.16.2016.10.10.06.03.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Oct 2016 06:03:02 -0700 (PDT) Date: Mon, 10 Oct 2016 09:02:53 -0400 From: Tejun Heo To: Michael Ellerman Subject: Re: Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Message-ID: <20161010130253.GB29742@mtj.duckdns.org> References: <1473967821-24363-1-git-send-email-tj@kernel.org> <1473967821-24363-2-git-send-email-tj@kernel.org> <20160917172314.GB10771@mtj.duckdns.org> <87twck5wqo.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87twck5wqo.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.7.0 (2016-08-17) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linuxppc-dev@lists.ozlabs.org" , jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, kernel-team@fb.com Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hello, Michael. On Mon, Oct 10, 2016 at 09:22:55PM +1100, Michael Ellerman wrote: > This patch seems to be causing one of my Power8 boxes not to boot. > > Specifically commit 3347fa092821 ("workqueue: make workqueue available > early during boot") in linux-next. > > If I revert this on top of next-20161005 then the machine boots again. > > I've attached the oops below. It looks like the cfs_rq of p->se is NULL? Hah, weird that it's arch dependent, or maybe it's just different config options. Most likely, it's caused by workqueue_init() call being moved too early. Can you please try the following patch and see whether the problem goes away? Thanks. diff --git a/init/main.c b/init/main.c index 5c4fd68..fe4fa47 100644 --- a/init/main.c +++ b/init/main.c @@ -1013,7 +1013,7 @@ static noinline void __init kernel_init_freeable(void) smp_prepare_cpus(setup_max_cpus); - workqueue_init(); + //workqueue_init(); do_pre_smp_initcalls(); lockup_detector_init(); diff --git a/kernel/workqueue.c b/kernel/workqueue.c index ad0cd43..400f5e2 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -5585,3 +5585,4 @@ int __init workqueue_init(void) return 0; } +early_initcall(workqueue_init);